Review main Merged

42410[BUGFIX] Remove SelectImage.initEventListener

Manuel Selbach CR +2 V +2 Easy +35 −6 updated 08/11/15, 11:42

Commit message

This removes the calls of SelectImage.initEventListener
and deprecate the method.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Daniel Maier +1
  • Verified V +2
    • Wouter Wolters +2
    • Daniel Maier +1

Issues 1

Files 3

Review log 9

  1. Manuel Selbach uploaded patch set 1 08/08/15, 14:12

  2. Manuel Selbach uploaded patch set 2 08/08/15, 14:24

  3. Wouter Wolters commented on patch set 2 08/08/15, 14:26

    Deprecation-68860-DeprecateSelectImageinitEventHandler.rst:8

    Why is the call removed? Maybe a bit more explanation here.
  4. Manuel Selbach uploaded patch set 3 08/09/15, 09:54

  5. Wouter Wolters voted on patch set 3 V +1 CR +1 08/09/15, 11:06

  6. Daniel Maier voted on patch set 3 CR +1 V +1 08/09/15, 21:18

  7. Wouter Wolters voted on patch set 3 V +2 CR +2 08/09/15, 21:30

  8. Wouter Wolters merged patch set 3 08/09/15, 21:30

  9. Markus Klein commented on patch set 4 08/11/15, 11:42

    Post -1. IMHO this is the wrong fix, the AMD function definition is simply plain wrong. See https://review.typo3.org/#/c/41760/5/typo3/sysext/rtehtmlarea/Resources/Public/JavaScript/Modules/SelectImage.js

    SelectImage.js:38

    spaces vs tabs