Review main Merged

42473[BUGFIX] Element Browser: checkDisplayThumbs: remove line break

Josef Glatz CR +2 V +2 Easy +2 −3 updated 01/09/19, 20:56

Commit message

Removes wrap between checkbox and label by adding proper markup.

Review

  • Code review CR +2
    • Benni Mack +2
    • Sebastian Fischer +1
    • Markus Günther +1
  • Verified V +2
    • Benni Mack +2
    • Markus Günther +1

Issues 1

Files 1

Review log 6

  1. Benni Mack voted on patch set 1 CR +1 V +1 01/09/19, 20:56

  2. Benni Mack voted on patch set 1 CR +2 V +2 01/09/19, 20:56

  3. Sebastian Fischer voted on patch set 1 CR +1 01/09/19, 20:56

  4. Markus Günther commented on patch set 1 CR +1 V +1 01/09/19, 20:56

    Looks good ... the checkbox it self is brocken at the moment but that happens also in master. So your fix works. But there seems to be an issue with the routing, when you click the thumbnail checkbox.
  5. Benni Mack merged patch set 1 01/09/19, 20:56

  6. Josef Glatz uploaded patch set 1 01/09/19, 20:56