Review main Merged

42485[BUGFIX] Checkbox "Display thumbnails" does not work in filebrowser

Manuel Selbach CR +2 V +2 Easy +8 −1 updated 01/09/19, 20:56

Commit message

Generates the link if a route is given and adds additional parameters.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Josef Glatz +1
    • Daniel Maier +1
  • Verified V +2
    • Wouter Wolters +2
    • Josef Glatz +1
    • Daniel Maier +1

Issues 1

Files 1

Review log 12

  1. Manuel Selbach uploaded patch set 1 08/10/15, 17:43

  2. Markus Günther commented on patch set 1 08/10/15, 18:16

    I still get this error when i try to add a image and click the checkbox in the element browser. I cleaned the cache and the autoload stuff...
  3. Markus Günther commented on patch set 1 08/10/15, 18:16

    http://snag.gy/wORrU.jpg forgot the image.
  4. Manuel Selbach commented on patch set 1 08/10/15, 18:35

    I reset my git and applied the patch. Cleared the caches (PHP opcache as weill), reloaded the backend and everything works fine.
  5. Wouter Wolters voted on patch set 1 V +1 CR +1 08/10/15, 18:41

  6. Daniel Maier commented on patch set 1 CR +1 V +1 08/10/15, 20:20

    Works for me, too
  7. Wouter Wolters voted on patch set 1 V +2 CR +2 08/10/15, 20:20

  8. Wouter Wolters merged patch set 1 08/10/15, 20:20

  9. Josef Glatz voted on patch set 1 CR +1 01/09/19, 20:56

  10. Josef Glatz commented on patch set 1 CR +1 V +1 01/09/19, 20:56

    I've cleared system caches from backend. @Markus: what do you mean with "add a image and click the checkbox"? I have no problem anymore with the Element Browser
  11. Josef Glatz commented on patch set 1 V +1 01/09/19, 20:56

    Could not reproduce the problem.
  12. Josef Glatz voted on patch set 1 CR 0 V 0 01/09/19, 20:56