Review main Merged

42492[TASK] Update to latest class alias loader version

Helmut Hummel CR +2 V +2 Normal +19 −38 updated 08/10/15, 22:50

Commit message

Benefit from several class alias loader package improvements:

* Use alias map API of this package to resolve and add aliases
* Use new option to force initialization of the alias loader to greatly simplify our runtime code
  This option is only evaluated in non composer mode, which is good because we only need it then.
* Adapt to API change, that now the alias loader is never returned from autoload inclusion

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Daniel Goerz +1
    • Wouter Wolters +1
  • Verified V +2
    • Stefan Neufeind +2
    • Daniel Goerz +1
    • Wouter Wolters +1

Issues 1

Files 8

Review log 12

  1. Helmut Hummel uploaded patch set 1 08/10/15, 21:06

  2. Daniel Goerz commented on patch set 1 CR +1 08/10/15, 21:13

    add, I guess :)
  3. Stefan Neufeind commented on patch set 1 CR +1 08/10/15, 21:15

    Reply

    my ass! :-)
  4. Stefan Neufeind voted on patch set 1 V +1 08/10/15, 21:17

  5. Helmut Hummel updated the commit message in patch set 2 08/10/15, 21:28

  6. Wouter Wolters voted on patch set 2 CR +1 08/10/15, 21:30

  7. Daniel Goerz voted on patch set 2 CR +1 08/10/15, 21:32

  8. Wouter Wolters voted on patch set 2 V +1 08/10/15, 21:33

  9. Daniel Goerz commented on patch set 2 V +1 08/10/15, 21:51

    No class loading issues found
  10. Stefan Neufeind voted on patch set 2 CR +1 V +1 08/10/15, 22:04

  11. Stefan Neufeind commented on patch set 2 CR +2 V +2 08/10/15, 22:50

    Helmut suggested to try enabling/disabling compatibility6. That also worked fine for me so far, with and without
  12. Stefan Neufeind merged patch set 2 08/10/15, 22:50