Review main Abandoned

4252[BUGFIX] allow suggest wizard in FlexForms

Sebastian Kurfuerst CR 0 V 0 Easy +13 −0 updated 06/03/13, 20:49

Commit message

By default only fields configured in TCA can use Wizard->Suggest feature
introduced in ver. 4.3. Thanks to small modifications it is also possible to
suggest related records in FlexForms.

Thanks to Marcus Biesiorof for the patch.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 12

  1. Björn Pedersen commented on patch set 1 12/19/11, 14:27

    I would prefer that you didn't submit this The Array -> string -> array conversion is not ideal. Idea: In case of a pi_flexform, the parsed config is already present, so just inject that instead of the normal TCA config.
  2. Björn Pedersen commented on patch set 1 12/19/11, 14:27

    (1 inline comment)
  3. Markus Klein commented on patch set 2 12/19/11, 14:27

    Fails; I would prefer that you didn't submit this Already merged in https://review.typo3.org/5703 Abandon this one, now!!!
  4. Oliver Hader uploaded patch set 2 12/19/11, 14:27

  5. Oliver Hader commented on patch set 2 12/19/11, 14:27

    Fails; I would prefer that you didn't submit this Rebasing to master V:-1, R:-1 V:0, R:-1 from Björn Pedersen <bjoern.pedersen@frm2.tum.de> V:-1, R:1 from Georg Ringer <mail@ringerge.org>
  6. Georg Ringer commented on patch set 1 12/19/11, 14:27

    there is a working review, see https://review.typo3.org/#change,5703 wanna abandon this one?

    class.t3lib_tceforms_suggest.php:67

    === should be used
  7. Georg Ringer commented on patch set 1 1 comment 12/19/11, 14:27

    Looks good to me, but someone else must approve
  8. Georg Ringer commented on patch set 1 12/19/11, 14:27

    Fails please see my comments in forge entry
  9. Georg Ringer commented on patch set 2 12/19/11, 14:27

    Fails; Do not submit
  10. Mr. Jenkins commented on patch set 1 12/19/11, 14:27

  11. Mr. Jenkins commented on patch set 2 12/19/11, 14:27

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/2683/ : FAILURE
  12. Sebastian Kurfuerst commented on patch set 2 12/19/11, 14:27

    Abandoned abandoning, thx