4252[BUGFIX] allow suggest wizard in FlexForms
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 12
-
Björn Pedersen commented on patch set 1 12/19/11, 14:27
I would prefer that you didn't submit this The Array -> string -> array conversion is not ideal. Idea: In case of a pi_flexform, the parsed config is already present, so just inject that instead of the normal TCA config. -
Björn Pedersen commented on patch set 1 12/19/11, 14:27
(1 inline comment) -
Markus Klein commented on patch set 2 12/19/11, 14:27
Fails; I would prefer that you didn't submit this Already merged in https://review.typo3.org/5703 Abandon this one, now!!! -
Oliver Hader uploaded patch set 2 12/19/11, 14:27
-
Oliver Hader commented on patch set 2 12/19/11, 14:27
Fails; I would prefer that you didn't submit this Rebasing to master V:-1, R:-1 V:0, R:-1 from Björn Pedersen <bjoern.pedersen@frm2.tum.de> V:-1, R:1 from Georg Ringer <mail@ringerge.org> -
Georg Ringer commented on patch set 1 12/19/11, 14:27
there is a working review, see https://review.typo3.org/#change,5703 wanna abandon this one?class.t3lib_tceforms_suggest.php:67=== should be used -
Georg Ringer commented on patch set 1 1 comment 12/19/11, 14:27
Looks good to me, but someone else must approve -
Georg Ringer commented on patch set 1 12/19/11, 14:27
Fails please see my comments in forge entry -
Georg Ringer commented on patch set 2 12/19/11, 14:27
Fails; Do not submit -
Mr. Jenkins commented on patch set 1 12/19/11, 14:27
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1611/ : SUCCESS -
Mr. Jenkins commented on patch set 2 12/19/11, 14:27
Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/2683/ : FAILURE -
Sebastian Kurfuerst commented on patch set 2 12/19/11, 14:27
Abandoned abandoning, thx