Review main Merged Breaking

42562[FOLLOWUP][!!!][TASK] Move deprecated entrypoints to deprecated.php

Benni Mack CR +2 V +2 Easy +4 −1 updated 11/10/16, 10:30

Commit message

Ensure rewrite rules of main .htaccess files are still in actions.
This is required for protection mechanismns and version number
in file names.

Review

  • Code review CR +2
    • Markus Klein +2
  • Verified V +2
    • Markus Klein +2

Issues 1

Files 1

Review log 8

  1. Benni Mack uploaded patch set 1 08/13/15, 11:36

  2. Markus Klein commented on patch set 1 08/13/15, 12:09

    IMO it does not suffice to have those few rules, we need the protection rules as well and all the stuff
  3. Benni Mack uploaded patch set 2 08/13/15, 12:14

  4. Markus Klein updated the commit message in patch set 3 08/13/15, 12:35

  5. Markus Klein voted on patch set 3 CR +1 V +1 08/13/15, 12:35

  6. Markus Klein voted on patch set 3 CR +2 V +2 08/13/15, 12:35

  7. Markus Klein merged patch set 3 08/13/15, 12:35

  8. Alexander Opitz commented on patch set 4 11/10/16, 10:30

    .htaccess:6

    This is not nice, as we take over all RewriteRules, also for example Language Selected redirects.