42586[BUGFIX] Re-introduce WebDAV-related HTTP methods
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Nicole Hummel +1
-
Verified V +2
- Benni Mack +2
- Nicole Hummel +1
Issues 1
Files 1
Review log 17
-
Gerrit Mohrmann uploaded patch set 1 08/13/15, 15:02
-
Benni Mack commented on patch set 1 CR -1 08/18/15, 16:15
Hey Gerrit. Thanks for that patch. How about we do this inside handleRequest() of the bootstrap ? -
Gerrit Mohrmann commented on patch set 1 08/19/15, 12:16
For some Signal/Hook it is too late in $bootstrap->handleRequest(). The request is blocked with constructing the ServerRequest. Extending the $supportedMethods[] with all webdav methods will work, but is there a reason that typo3 blocking these methods? -
Benni Mack commented on patch set 1 08/20/15, 10:12
Nope. But the Request was just the default from PSR-7 - I'm fine with extending it for WebDAV. Or we create a WebDAV Response extending the regular response object -
Gerrit Mohrmann commented on patch set 1 08/22/15, 10:14
I can push a patch with the WebDav methods in the supportedMethods when it is needed. But I'am not sure what you have in mind with a WebDav Response. Unfortunately I can't change the title in forge to throwing the signal away... BTW is it planed to make it possible to register an own requestHandler? Or have I overread in the code that this is possible? -
Benni Mack commented on patch set 1 09/17/15, 07:24
Hey, please add all needed HTTP options to TYPO3\CMS\Core\Http\Request (you can use this patchset for it). -
Gerrit Mohrmann uploaded patch set 2 09/18/15, 11:51
-
Benni Mack commented on patch set 2 09/18/15, 12:51
could you also write to the added lines // WEBDAV extension and also a RsT file that this is now possible. -
Gerrit Mohrmann uploaded patch set 3 09/18/15, 18:40
-
Benni Mack commented on patch set 3 CR +1 09/18/15, 18:45
Cool thing, thanks! How to test? Do you have an extension at hand? -
Benni Mack commented on patch set 3 V +1 09/19/15, 20:41
I consider this a bugfix since WebDAV support is broken since the introduction of PSR-7 (= TYPO3 7.4). Test it via curl -X PROPFIND http://mydomain/ -
Benni Mack uploaded patch set 4 09/19/15, 20:43
-
Benni Mack voted on patch set 4 CR +1 V +1 09/19/15, 20:43
-
Nicole Hummel uploaded patch set 5 09/20/15, 17:46
-
Nicole Hummel commented on patch set 5 CR +1 V +1 09/20/15, 17:47
Just prefer another grouping for the methods so we can extend those if necessary. -
Benni Mack commented on patch set 5 CR +2 V +2 09/21/15, 05:22
cool. thanks! -
Benni Mack merged patch set 5 09/21/15, 05:22