Review TYPO3_6-2 Merged

42590[BUGFIX] Allow subclasses of \DateTime as entity properties

Stephan Großberndt CR +2 V +2 Easy +42 −4 updated 08/13/15, 19:34

Commit message

When a class "\MyCustomDateTime extends \DateTime", the data mapper
creates "\DateTime" objects instead when mapping database results.
This patch uses the class annotation to resolve the class to create.

Review

  • Code review CR +2
    • Andreas Wolf +2
  • Verified V +2
    • Andreas Wolf +2

Issues 1

Files 3

Review log 6

  1. Stephan Großberndt uploaded patch set 1 08/13/15, 15:50

  2. Stephan Großberndt commented on patch set 1 08/13/15, 15:58

  3. Andreas Wolf commented on patch set 1 08/13/15, 17:16

    Should be safe to merge after the unit tests ran through successfully.
  4. Stephan Großberndt commented on patch set 1 08/13/15, 17:42

    Unit tests on windows ran through. Travis pre-merge is not available currently :-(
  5. Andreas Wolf voted on patch set 1 CR +2 V +2 08/13/15, 19:34

  6. Andreas Wolf merged patch set 1 08/13/15, 19:34