Review main Merged

42597[TASK] Drop type=select neg_foreign_table

Christian Kuhn CR +2 V +2 Normal +108 −61 updated 08/13/15, 20:19

Commit message

Drop the functionality to store relations to a second table
in type=select fields as negative uid values.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Frank Nägler +1
    • Benni Mack +1
  • Verified V +2
    • Anja Leichsenring +2
    • Frank Nägler +1

Issues 1

Files 11

Review log 8

  1. Christian Kuhn uploaded patch set 1 08/13/15, 17:20

  2. Christian Kuhn commented on patch set 1 08/13/15, 17:26

    DataPreprocessor.php:783

    could be further simplified, but never mind, this class will be deleted by my monster ...

    BackendUtility.php:3451

    full method will be deprecated by my monster later ...
  3. Benni Mack voted on patch set 1 CR +1 08/13/15, 18:51

  4. Frank Nägler voted on patch set 1 CR +1 08/13/15, 19:00

  5. Frank Nägler commented on patch set 1 V +1 08/13/15, 19:25

    backend works, unit test and functional test running without problems.
  6. Christian Kuhn commented on patch set 1 08/13/15, 19:28

    thx 4 quick reviews! i'm a bit under pressure with this one ...
  7. Anja Leichsenring voted on patch set 1 CR +2 V +2 08/13/15, 20:19

  8. Anja Leichsenring merged patch set 1 08/13/15, 20:19