42601[FOLLOWUP][FEATURE] Introduce AvatarProvider
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Morton Jonuschat +1
-
Verified V +2
- Markus Klein +2
- Morton Jonuschat +1
Issues 1
Files 7
- typo3/sysext/backend/Classes/Backend/Avatar/Avatar.php+4 −4
- typo3/sysext/backend/Classes/Backend/Avatar/AvatarProviderInterface.php+1 −1
- typo3/sysext/backend/Classes/Backend/Avatar/DefaultAvatarProvider.phprenamed+4 −4
- typo3/sysext/backend/Classes/Backend/Avatar/Image.php3+15 −4
- typo3/sysext/backend/ext_localconf.php1+2 −2
- typo3/sysext/core/Documentation/Changelog/master/Feature-68429-IntroducedAvatarProviderAPI.rst2+15 −15
- typo3/sysext/setup/Classes/Controller/SetupModuleController.php2+4 −4
Review log 24
-
Frans Saris uploaded patch set 1 08/14/15, 06:37
-
Morton Jonuschat voted on patch set 1 CR +1 08/14/15, 06:54
-
Morton Jonuschat commented on patch set 1 V -1 08/14/15, 07:17
Adding a new avatar fails, On chrome I get a broken image icon instead of the avatar. Path to icon before change: ../fileadmin/user_upload/ente.png Path to icon after change: fileadmin/user_upload/ente.png -
Frans Saris uploaded patch set 2 08/14/15, 07:25
-
Helmut Hummel commented on patch set 2 08/14/15, 07:49
ImageProvider.php:25I still like this to be reamed: "I would even go one sept further and even name it: "UserSettingsProvider" as it is self-explanatory that it returns an image (is in Avatar namespace), but it is not clear, where this image is taken from the name" -
Frans Saris commented on patch set 2 08/14/15, 08:05
ImageProvider.php:25ReplyIMO the term "UserSettings" is a little bit out of place here. Other option could be "Default" so then it becomes: "DefaultProvider" -
Frans Saris commented on patch set 2 CR -1 V -1 08/14/15, 08:32
ImageProvider.php:25ReplyAfter some discussion on Slack we agreed rename it to: "DefaultAvatarProvider". Will update the patch this afternoon -
Stefan Neufeind uploaded patch set 3 08/14/15, 09:24
-
Stefan Neufeind commented on patch set 3 08/14/15, 09:24
renamed with phpstorm -
Frans Saris commented on patch set 3 CR -1 08/14/15, 09:56
ext_localconf.php:26defaultAvatarProviderFeature-68429-IntroducedAvatarProviderAPI.rst:39defaultAvatarProvider -
Stefan Neufeind uploaded patch set 4 08/14/15, 10:12
-
Stefan Neufeind commented on patch set 4 08/14/15, 10:15
@Frans: Sorry I missed the other occurences. Found 2 more.Feature-68429-IntroducedAvatarProviderAPI.rst:39renamed this to CustomAvatarProvider as wellSetupModuleController.php:608do we name that just "avatarProvider"? It's an instance of the default-provider, but for the usage here it imho does not matter if this is default or not -
Frans Saris commented on patch set 4 08/14/15, 11:32
SetupModuleController.php:608Replyimo this is ok, but could indeed be renamed to be consistent -
Frans Saris commented on patch set 4 08/14/15, 11:34
will push new patch -
Frans Saris uploaded patch set 5 08/14/15, 11:35
-
Morton Jonuschat voted on patch set 5 CR +1 V +1 08/15/15, 16:37
-
Markus Klein uploaded patch set 6 08/15/15, 17:48
-
Markus Klein voted on patch set 6 CR +1 08/15/15, 17:51
-
Morton Jonuschat voted on patch set 6 CR +1 V +1 08/15/15, 18:36
-
Markus Klein voted on patch set 6 CR +2 V +2 08/15/15, 21:32
-
Markus Klein merged patch set 6 08/15/15, 21:32
-
Nicole Hummel commented on patch set 7 08/16/15, 11:44
Post -1 Sorry for not being able to have a closer look to the patch before.Image.php:62Still think, that the image shouldn't care about the path but the API using it should care. -
Frans Saris commented on patch set 7 08/21/15, 16:02
Image.php:62ReplyMirrored this behaviour from FAL getPublicUrl($relativeToCurrentScript); But maybe we could move this logic to the PathUtility so there is a "easy" way to get the correct path and indeed remove it here.