Review main Merged

42601[FOLLOWUP][FEATURE] Introduce AvatarProvider

Frans Saris CR +2 V +2 Normal +45 −34 updated 08/21/15, 16:02

Commit message

Changed definition of Avatar/Image::url, renamed defaultAvatarProvider
and adjusted some typos in rst file.

Review

  • Code review CR +2
    • Markus Klein +2
    • Morton Jonuschat +1
  • Verified V +2
    • Markus Klein +2
    • Morton Jonuschat +1

Issues 1

Files 7

Review log 24

  1. Frans Saris uploaded patch set 1 08/14/15, 06:37

  2. Morton Jonuschat voted on patch set 1 CR +1 08/14/15, 06:54

  3. Morton Jonuschat commented on patch set 1 V -1 08/14/15, 07:17

    Adding a new avatar fails, On chrome I get a broken image icon instead of the avatar. Path to icon before change: ../fileadmin/user_upload/ente.png Path to icon after change: fileadmin/user_upload/ente.png
  4. Frans Saris uploaded patch set 2 08/14/15, 07:25

  5. Helmut Hummel commented on patch set 2 08/14/15, 07:49

    ImageProvider.php:25

    I still like this to be reamed: "I would even go one sept further and even name it: "UserSettingsProvider" as it is self-explanatory that it returns an image (is in Avatar namespace), but it is not clear, where this image is taken from the name"
  6. Frans Saris commented on patch set 2 08/14/15, 08:05

    ImageProvider.php:25 Reply

    IMO the term "UserSettings" is a little bit out of place here. Other option could be "Default" so then it becomes: "DefaultProvider"
  7. Frans Saris commented on patch set 2 CR -1 V -1 08/14/15, 08:32

    ImageProvider.php:25 Reply

    After some discussion on Slack we agreed rename it to: "DefaultAvatarProvider". Will update the patch this afternoon
  8. Stefan Neufeind uploaded patch set 3 08/14/15, 09:24

  9. Stefan Neufeind commented on patch set 3 08/14/15, 09:24

    renamed with phpstorm
  10. Frans Saris commented on patch set 3 CR -1 08/14/15, 09:56

    ext_localconf.php:26

    defaultAvatarProvider

    Feature-68429-IntroducedAvatarProviderAPI.rst:39

    defaultAvatarProvider
  11. Stefan Neufeind uploaded patch set 4 08/14/15, 10:12

  12. Stefan Neufeind commented on patch set 4 08/14/15, 10:15

    @Frans: Sorry I missed the other occurences. Found 2 more.

    Feature-68429-IntroducedAvatarProviderAPI.rst:39

    renamed this to CustomAvatarProvider as well

    SetupModuleController.php:608

    do we name that just "avatarProvider"? It's an instance of the default-provider, but for the usage here it imho does not matter if this is default or not
  13. Frans Saris commented on patch set 4 08/14/15, 11:32

    SetupModuleController.php:608 Reply

    imo this is ok, but could indeed be renamed to be consistent
  14. Frans Saris commented on patch set 4 08/14/15, 11:34

    will push new patch
  15. Frans Saris uploaded patch set 5 08/14/15, 11:35

  16. Morton Jonuschat voted on patch set 5 CR +1 V +1 08/15/15, 16:37

  17. Markus Klein commented on patch set 5 08/15/15, 17:25

    only a nitpick

    Image.php:65

    space missing
  18. Markus Klein uploaded patch set 6 08/15/15, 17:48

  19. Markus Klein voted on patch set 6 CR +1 08/15/15, 17:51

  20. Morton Jonuschat voted on patch set 6 CR +1 V +1 08/15/15, 18:36

  21. Markus Klein voted on patch set 6 CR +2 V +2 08/15/15, 21:32

  22. Markus Klein merged patch set 6 08/15/15, 21:32

  23. Nicole Hummel commented on patch set 7 08/16/15, 11:44

    Post -1 Sorry for not being able to have a closer look to the patch before.

    Image.php:62

    Still think, that the image shouldn't care about the path but the API using it should care.
  24. Frans Saris commented on patch set 7 08/21/15, 16:02

    Image.php:62 Reply

    Mirrored this behaviour from FAL getPublicUrl($relativeToCurrentScript); But maybe we could move this logic to the PathUtility so there is a "easy" way to get the correct path and indeed remove it here.