42618[TASK] Prettify some edges of the Record History
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Stefan Neufeind +1
- Daniel Goerz +1
- Frank Nägler +1
-
Verified V +2
- Markus Klein +2
- Daniel Goerz +1
- Frank Nägler +1
Issues 1
Files 2
Review log 37
Show 12 earlier messages
-
Jan Helke uploaded patch set 1 08/14/15, 15:45
-
Stefan Neufeind commented on patch set 1 CR +1 V +1 08/15/15, 17:11
In the preview still the title is quite close to be buttons in front. But that was the case before as well. We might fix that in one go - but the changes done here are already a great enhancement imho. -
Markus Klein updated the commit message in patch set 2 08/16/15, 11:11
-
Markus Klein commented on patch set 2 08/16/15, 11:16
RecordHistory.php:326IMO this is really hard to read. * long lines * operator precedence must be exactly known to the devRecordHistory.php:337is this hsc()'d ?RecordHistory.php:489pls shorten namespacesRecordHistory.php:547can this inline CSS be moved to the less files? -
Daniel Goerz commented on patch set 2 08/16/15, 17:23
RecordHistory.php:337Replyit's hardoced from above. Should we hsc() it anyway? -
Daniel Goerz commented on patch set 2 08/18/15, 21:46
I am not sure about this one. Given a fairly long list the user might never find them down there. -
Jan Helke uploaded patch set 3 08/21/15, 08:39
-
Jan Helke commented on patch set 2 08/21/15, 08:43
RecordHistory.php:326ReplyImproved that a bit.RecordHistory.php:337ReplyDoneRecordHistory.php:489ReplyDoneRecordHistory.php:547ReplyTo be honest, that is still ugly and I would like to avoid to pollute more files with that. -
Benni Mack commented on patch set 2 08/21/15, 11:20
RecordHistory.php:547Replyyes. let's change it separately. -
Benni Mack voted on patch set 3 CR +1 08/21/15, 11:20
-
Stefan Neufeind voted on patch set 3 CR +1 V +1 08/21/15, 16:22
-
Markus Klein commented on patch set 3 08/22/15, 08:34
RecordHistory.php:349this is useless
-
Markus Klein uploaded patch set 4 08/22/15, 08:37
-
Markus Klein commented on patch set 4 V -1 08/22/15, 08:38
I took a look now. I disagree about having the settings at the very bottom. That can be a very long list to scroll. Additionally, I would put these 4 settings in one row, next to each other, so they take up less space. -
Jan Helke commented on patch set 4 08/28/15, 10:29
To be honest, I don't care enough about the position of the settings to discuss that over a long time. So I will change that for the sake of a good merge. -
Jan Helke uploaded patch set 5 08/28/15, 10:36
-
Daniel Goerz commented on patch set 5 08/28/15, 14:20
RecordHistory.php:386maybe add a col-md-6 and/or col-lg-4? This looks really odd on large screens. -
Daniel Goerz commented on patch set 5 08/28/15, 14:25
RecordHistory.php:387We now have two elements inside the panel with a margin-bottom: * #typo3-docbody form {margin-bottom: 1.25em;} * .table {margin-bottom: 18px;} This results in an ugly gap between the end of the panel content and the bottom border of the panel. -
Daniel Goerz commented on patch set 5 08/28/15, 14:28
RecordHistory.php:508The FlashMessage already has a margin-bottom, so this <br /> could be removed. -
Jan Helke uploaded patch set 6 09/04/15, 08:56
-
Jan Helke commented on patch set 5 09/04/15, 08:56
RecordHistory.php:386ReplyDoneRecordHistory.php:387ReplyDoneRecordHistory.php:508ReplyDone -
Jan Helke uploaded patch set 7 09/04/15, 09:23
-
Markus Sommer commented on patch set 7 CR +1 V +1 09/04/15, 09:26
Looks Prettify :) and works fine -
Daniel Goerz voted on patch set 7 CR +1 V +1 09/04/15, 09:40
-
Markus Klein commented on patch set 7 CR -1 09/04/15, 10:23
RecordHistory.php:336ternaries start on new line.RecordHistory.php:337please put parenthesis around those nested ternaries -
Stefan Neufeind uploaded patch set 8 09/04/15, 10:25
-
Stefan Neufeind commented on patch set 8 CR +1 V +1 09/04/15, 10:50
code-formatting adjusted (thanks to Markus) -
Markus Sommer voted on patch set 8 CR +1 V +1 09/04/15, 11:28
-
Frank Nägler commented on patch set 8 CR -1 09/04/15, 13:27
RecordHistory.php:504bad idea, use callout. will push an update -
Frank Nägler uploaded patch set 9 09/04/15, 13:30
-
Frank Nägler voted on patch set 9 CR +1 V +1 09/04/15, 13:31
-
Jan Helke commented on patch set 9 09/04/15, 15:11
Cool. Like that. -
Stefan Neufeind voted on patch set 9 CR +1 09/04/15, 15:30
-
Daniel Goerz voted on patch set 9 CR +1 V +1 09/04/15, 20:43
-
Markus Klein voted on patch set 9 CR +1 V +1 09/05/15, 10:26
-
Markus Klein voted on patch set 9 CR +2 V +2 09/05/15, 10:26
-
Markus Klein merged patch set 9 09/05/15, 10:26