Review main Merged

42618[TASK] Prettify some edges of the Record History

Jan Helke CR +2 V +2 Normal +71 −17 updated 09/05/15, 10:26

Commit message

This patch gives some love to the Record History and prettifies some
things.

On the Changelog View:
- Column with the Rollback icons is now labeled with "Rollback"
- Rollback icon is changed from arrows to the spinning clock which the
  user already spotted in the page menu.
- The settings and drop downs are now wrapped with TWBS styles.

On the Preview View:
- The single changes are indented a little bit more, the black strip
  is now a gray bar that comprises the sections better.
- The tiny link with the two downward arrows at the end of the
  Changelog list is now a clear visible button with a readable label.

Review

  • Code review CR +2
    • Markus Klein +2
    • Stefan Neufeind +1
    • Daniel Goerz +1
    • Frank Nägler +1
  • Verified V +2
    • Markus Klein +2
    • Daniel Goerz +1
    • Frank Nägler +1

Issues 1

Files 2

Review log 37

Show 12 earlier messages
  1. Jan Helke uploaded patch set 1 08/14/15, 15:45

  2. Stefan Neufeind commented on patch set 1 CR +1 V +1 08/15/15, 17:11

    In the preview still the title is quite close to be buttons in front. But that was the case before as well. We might fix that in one go - but the changes done here are already a great enhancement imho.
  3. Markus Klein updated the commit message in patch set 2 08/16/15, 11:11

  4. Markus Klein commented on patch set 2 08/16/15, 11:16

    RecordHistory.php:326

    IMO this is really hard to read. * long lines * operator precedence must be exactly known to the dev

    RecordHistory.php:337

    is this hsc()'d ?

    RecordHistory.php:489

    pls shorten namespaces

    RecordHistory.php:547

    can this inline CSS be moved to the less files?
  5. Daniel Goerz commented on patch set 2 08/16/15, 17:23

    RecordHistory.php:337 Reply

    it's hardoced from above. Should we hsc() it anyway?
  6. Daniel Goerz commented on patch set 2 08/18/15, 21:46

    I am not sure about this one. Given a fairly long list the user might never find them down there.
  7. Jan Helke uploaded patch set 3 08/21/15, 08:39

  8. Jan Helke commented on patch set 2 08/21/15, 08:43

    RecordHistory.php:326 Reply

    Improved that a bit.

    RecordHistory.php:337 Reply

    Done

    RecordHistory.php:489 Reply

    Done

    RecordHistory.php:547 Reply

    To be honest, that is still ugly and I would like to avoid to pollute more files with that.
  9. Benni Mack commented on patch set 2 08/21/15, 11:20

    RecordHistory.php:547 Reply

    yes. let's change it separately.
  10. Benni Mack voted on patch set 3 CR +1 08/21/15, 11:20

  11. Stefan Neufeind voted on patch set 3 CR +1 V +1 08/21/15, 16:22

  12. Markus Klein commented on patch set 3 08/22/15, 08:34

    RecordHistory.php:349

    this is useless
  1. Markus Klein uploaded patch set 4 08/22/15, 08:37

  2. Markus Klein commented on patch set 4 V -1 08/22/15, 08:38

    I took a look now. I disagree about having the settings at the very bottom. That can be a very long list to scroll. Additionally, I would put these 4 settings in one row, next to each other, so they take up less space.
  3. Jan Helke commented on patch set 4 08/28/15, 10:29

    To be honest, I don't care enough about the position of the settings to discuss that over a long time. So I will change that for the sake of a good merge.
  4. Jan Helke uploaded patch set 5 08/28/15, 10:36

  5. Daniel Goerz commented on patch set 5 08/28/15, 14:20

    RecordHistory.php:386

    maybe add a col-md-6 and/or col-lg-4? This looks really odd on large screens.
  6. Daniel Goerz commented on patch set 5 08/28/15, 14:25

    RecordHistory.php:387

    We now have two elements inside the panel with a margin-bottom: * #typo3-docbody form {margin-bottom: 1.25em;} * .table {margin-bottom: 18px;} This results in an ugly gap between the end of the panel content and the bottom border of the panel.
  7. Daniel Goerz commented on patch set 5 08/28/15, 14:28

    RecordHistory.php:508

    The FlashMessage already has a margin-bottom, so this <br /> could be removed.
  8. Jan Helke uploaded patch set 6 09/04/15, 08:56

  9. Jan Helke commented on patch set 5 09/04/15, 08:56

    RecordHistory.php:386 Reply

    Done

    RecordHistory.php:387 Reply

    Done

    RecordHistory.php:508 Reply

    Done
  10. Jan Helke uploaded patch set 7 09/04/15, 09:23

  11. Markus Sommer commented on patch set 7 CR +1 V +1 09/04/15, 09:26

    Looks Prettify :) and works fine
  12. Daniel Goerz voted on patch set 7 CR +1 V +1 09/04/15, 09:40

  13. Markus Klein commented on patch set 7 CR -1 09/04/15, 10:23

    RecordHistory.php:336

    ternaries start on new line.

    RecordHistory.php:337

    please put parenthesis around those nested ternaries
  14. Stefan Neufeind uploaded patch set 8 09/04/15, 10:25

  15. Stefan Neufeind commented on patch set 8 CR +1 V +1 09/04/15, 10:50

    code-formatting adjusted (thanks to Markus)
  16. Markus Sommer voted on patch set 8 CR +1 V +1 09/04/15, 11:28

  17. Frank Nägler commented on patch set 8 CR -1 09/04/15, 13:27

    RecordHistory.php:504

    bad idea, use callout. will push an update
  18. Frank Nägler uploaded patch set 9 09/04/15, 13:30

  19. Frank Nägler voted on patch set 9 CR +1 V +1 09/04/15, 13:31

  20. Jan Helke commented on patch set 9 09/04/15, 15:11

    Cool. Like that.
  21. Stefan Neufeind voted on patch set 9 CR +1 09/04/15, 15:30

  22. Daniel Goerz voted on patch set 9 CR +1 V +1 09/04/15, 20:43

  23. Markus Klein voted on patch set 9 CR +1 V +1 09/05/15, 10:26

  24. Markus Klein voted on patch set 9 CR +2 V +2 09/05/15, 10:26

  25. Markus Klein merged patch set 9 09/05/15, 10:26