Review main Merged

42643[TASK] Properly escape all form attributes in SetupModuleController

Stefan Neufeind CR +2 V +2 Normal +32 −32 updated 03/10/16, 17:10

Commit message

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Daniel Goerz +1
    • Markus Klein +1
  • Verified V +2
    • Jigal van Hemert +2
    • Daniel Goerz +1
    • Markus Klein +1

Issues 1

Files 2

Review log 37

Show 12 earlier messages
  1. Stefan Neufeind uploaded patch set 1 08/15/15, 12:54

  2. Stefan Neufeind commented on patch set 1 08/15/15, 12:56

    SetupModuleController.php:327

    we hsc it in other places as well

    SetupModuleController.php:425

    doesn't really need hsc. still do, to be consistent?

    SetupModuleController.php:463

    title is escaped later when being integrated with the spriteicon, have it without hsc here

    SetupModuleController.php:747

    at least one pair of brackets too much. but imho pulling the hsc out to the line below makes it more readable
  3. Stefan Neufeind commented on patch set 1 08/15/15, 12:58

    Backport might not apply clean. But upon a quick look there are some cases which exist in 6.2 as well.
  4. Stefan Neufeind uploaded patch set 2 10/15/15, 22:38

  5. Markus Klein commented on patch set 2 10/15/15, 22:46

    SetupModuleController.php:653

    result is already hsc'd

    SetupModuleController.php:697

    $label goes through getCSH() and is html
  6. Stefan Neufeind commented on patch set 2 10/15/15, 23:31

    SetupModuleController.php:653 Reply

    ack, thanks. I also saw now that getLabel() has a comment in @return that it returns HTML-output. Will remove the hsc-call with next patchset then.

    SetupModuleController.php:697 Reply

    ack, same as with getLabel(). Also also has a proper comment in @return already. Will remove those hsc-calls.
  7. Stefan Neufeind uploaded patch set 3 10/15/15, 23:32

  8. Stefan Neufeind uploaded patch set 4 11/20/15, 14:34

  9. Markus Klein commented on patch set 4 CR -1 11/20/15, 15:50

    SetupModuleController.php:827

    hsc() function pls, and CGL

    SetupModuleController.php:870

    same here
  10. Stefan Neufeind uploaded patch set 5 11/20/15, 17:28

  11. Benni Mack voted on patch set 5 CR +1 12/04/15, 09:12

  12. Frank Nägler commented on patch set 5 CR -1 12/04/15, 11:09

    SetupModuleController.php:151

    type int and empty string as default!?
  1. Benni Mack wrote 03/06/16, 10:52

    Patch set 6: Published edit on patch set 5.
  2. Benni Mack wrote 03/06/16, 11:00

    Patch set 7: Commit message was updated.
  3. Daniel Goerz commented on patch set 7 CR -1 03/06/16, 12:17

    on it
  4. Daniel Goerz uploaded patch set 8 03/06/16, 12:26

  5. Daniel Goerz voted on patch set 8 CR +1 03/06/16, 12:29

  6. Daniel Goerz voted on patch set 8 V +1 03/06/16, 12:41

  7. Wouter Wolters voted on patch set 8 CR +1 03/06/16, 16:00

  8. Benni Mack commented on patch set 8 V -1 03/06/16, 16:28

    Fields like "Recursive copy" no contain escaped bold tags.
  9. Daniel Goerz voted on patch set 8 CR 0 V 0 03/06/16, 16:53

  10. Daniel Goerz commented on patch set 8 03/06/16, 17:00

    SetupModuleController.php:831

    So, do we just remove the hsc here? I am not quite sure how to act correctly here.
  11. Daniel Goerz uploaded patch set 9 03/07/16, 09:08

  12. Daniel Goerz voted on patch set 9 CR +1 V +1 03/07/16, 09:20

  13. Markus Klein commented on patch set 9 03/07/16, 09:22

    SetupModuleController.php:788

    our goal is to get rid of this parameter and to use hsc() explicitly on the returned value.

    SetupModuleController.php:831

    same here
  14. Markus Klein wrote 03/07/16, 09:23

    Patch set 10: Published edit on patch set 9.
  15. Daniel Goerz commented on patch set 9 03/07/16, 09:24

    SetupModuleController.php:788 Reply

    Ah, I was not aware of that. Will adapt.
  16. Daniel Goerz commented on patch set 9 03/07/16, 09:25

    SetupModuleController.php:788 Reply

    Thanks
  17. Daniel Goerz voted on patch set 10 CR +1 V +1 03/07/16, 09:35

  18. Frank Nägler commented on patch set 10 CR -1 03/07/16, 12:46

    temp -1, please see my inline comment

    SetupModuleController.php:752

    why double (( ?
  19. Daniel Goerz commented on patch set 10 03/07/16, 13:36

    SetupModuleController.php:752 Reply

    Well, those are removed now, right?
  20. Markus Klein voted on patch set 10 CR +1 V +1 03/10/16, 16:46

  21. Frank Nägler voted on patch set 10 CR 0 03/10/16, 17:00

  22. Frank Nägler commented on patch set 10 03/10/16, 17:01

    SetupModuleController.php:752 Reply

    yes, don't know why I wrote this comment -.- removed my voting
  23. Jigal van Hemert voted on patch set 10 CR +2 V +2 03/10/16, 17:09

  24. Gerrit merged patch set 10 03/10/16, 17:09

  25. Jigal van Hemert commented on patch set 11 03/10/16, 17:10

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 5c9f507568d76f34f61bb3f2dc26c82ccb9a48c3