42643[TASK] Properly escape all form attributes in SetupModuleController
Commit message
Review
-
Code review CR +2
- Jigal van Hemert +2
- Daniel Goerz +1
- Markus Klein +1
-
Verified V +2
- Jigal van Hemert +2
- Daniel Goerz +1
- Markus Klein +1
Issues 1
Files 2
Review log 37
Show 12 earlier messages
-
Stefan Neufeind uploaded patch set 1 08/15/15, 12:54
-
Stefan Neufeind commented on patch set 1 08/15/15, 12:56
SetupModuleController.php:425doesn't really need hsc. still do, to be consistent?SetupModuleController.php:463title is escaped later when being integrated with the spriteicon, have it without hsc hereSetupModuleController.php:747at least one pair of brackets too much. but imho pulling the hsc out to the line below makes it more readable -
Stefan Neufeind commented on patch set 1 08/15/15, 12:58
Backport might not apply clean. But upon a quick look there are some cases which exist in 6.2 as well. -
Stefan Neufeind uploaded patch set 2 10/15/15, 22:38
-
Markus Klein commented on patch set 2 10/15/15, 22:46
SetupModuleController.php:653result is already hsc'dSetupModuleController.php:697$label goes through getCSH() and is html -
Stefan Neufeind commented on patch set 2 10/15/15, 23:31
SetupModuleController.php:653Replyack, thanks. I also saw now that getLabel() has a comment in @return that it returns HTML-output. Will remove the hsc-call with next patchset then.SetupModuleController.php:697Replyack, same as with getLabel(). Also also has a proper comment in @return already. Will remove those hsc-calls. -
Stefan Neufeind uploaded patch set 3 10/15/15, 23:32
-
Stefan Neufeind uploaded patch set 4 11/20/15, 14:34
-
Markus Klein commented on patch set 4 CR -1 11/20/15, 15:50
SetupModuleController.php:827hsc() function pls, and CGLSetupModuleController.php:870same here -
Stefan Neufeind uploaded patch set 5 11/20/15, 17:28
-
Benni Mack voted on patch set 5 CR +1 12/04/15, 09:12
-
Frank Nägler commented on patch set 5 CR -1 12/04/15, 11:09
SetupModuleController.php:151type int and empty string as default!?
-
Benni Mack wrote 03/06/16, 10:52
Patch set 6: Published edit on patch set 5. -
Benni Mack wrote 03/06/16, 11:00
Patch set 7: Commit message was updated. -
Daniel Goerz commented on patch set 7 CR -1 03/06/16, 12:17
on it -
Daniel Goerz uploaded patch set 8 03/06/16, 12:26
-
Daniel Goerz voted on patch set 8 CR +1 03/06/16, 12:29
-
Daniel Goerz voted on patch set 8 V +1 03/06/16, 12:41
-
Wouter Wolters voted on patch set 8 CR +1 03/06/16, 16:00
-
Benni Mack commented on patch set 8 V -1 03/06/16, 16:28
Fields like "Recursive copy" no contain escaped bold tags. -
Daniel Goerz voted on patch set 8 CR 0 V 0 03/06/16, 16:53
-
Daniel Goerz commented on patch set 8 03/06/16, 17:00
SetupModuleController.php:831So, do we just remove the hsc here? I am not quite sure how to act correctly here. -
Daniel Goerz uploaded patch set 9 03/07/16, 09:08
-
Daniel Goerz voted on patch set 9 CR +1 V +1 03/07/16, 09:20
-
Markus Klein commented on patch set 9 03/07/16, 09:22
SetupModuleController.php:788our goal is to get rid of this parameter and to use hsc() explicitly on the returned value.SetupModuleController.php:831same here -
Markus Klein wrote 03/07/16, 09:23
Patch set 10: Published edit on patch set 9. -
Daniel Goerz commented on patch set 9 03/07/16, 09:24
SetupModuleController.php:788ReplyAh, I was not aware of that. Will adapt. -
Daniel Goerz commented on patch set 9 03/07/16, 09:25
SetupModuleController.php:788ReplyThanks -
Daniel Goerz voted on patch set 10 CR +1 V +1 03/07/16, 09:35
-
Frank Nägler commented on patch set 10 CR -1 03/07/16, 12:46
temp -1, please see my inline commentSetupModuleController.php:752why double (( ? -
Daniel Goerz commented on patch set 10 03/07/16, 13:36
SetupModuleController.php:752ReplyWell, those are removed now, right? -
Markus Klein voted on patch set 10 CR +1 V +1 03/10/16, 16:46
-
Frank Nägler voted on patch set 10 CR 0 03/10/16, 17:00
-
Frank Nägler commented on patch set 10 03/10/16, 17:01
SetupModuleController.php:752Replyyes, don't know why I wrote this comment -.- removed my voting -
Jigal van Hemert voted on patch set 10 CR +2 V +2 03/10/16, 17:09
-
Gerrit merged patch set 10 03/10/16, 17:09
-
Jigal van Hemert commented on patch set 11 03/10/16, 17:10
Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 5c9f507568d76f34f61bb3f2dc26c82ccb9a48c3
SetupModuleController.php:327