Review main Merged

42717[BUGFIX] Log exception as array instead of serialized

Stephan Großberndt CR +2 V +2 Easy +14 −7 updated 08/18/15, 22:23

Commit message

Log exceptions thrown by scheduler tasks as array instead of
serializing the whole exception in order to keep the size down.

Review

  • Code review CR +2
    • Markus Klein +2
    • Daniel Goerz +1
    • Wouter Wolters +1
  • Verified V +2
    • Markus Klein +2
    • Daniel Goerz +1

Issues 1

Files 2

Review log 15

  1. Stephan Großberndt uploaded patch set 1 08/18/15, 14:55

  2. Markus Klein commented on patch set 1 08/18/15, 15:35

    How can it be that your exception had 53 MB ?? IMO the stack trace is what is important
  3. Frans Saris commented on patch set 1 CR +1 08/18/15, 16:45

    We had similar problems, full back trace get saved, but somehow it doesn't fit in db column or something with as result that unserializing fails and BE breaks. Maybe make it dependent to context, so in production only log the string.
  4. Frans Saris commented on patch set 1 08/18/15, 16:47

    Or we use the logging functionality to push the full backtrace
  5. Markus Klein commented on patch set 1 08/18/15, 16:57

    I would appreciate the logging API
  6. Markus Klein voted on patch set 1 CR +1 V +1 08/18/15, 17:42

  7. Wouter Wolters voted on patch set 1 CR +1 08/18/15, 17:45

  8. Markus Klein voted on patch set 1 CR -1 V -1 08/18/15, 18:05

  9. Markus Klein commented on patch set 1 08/18/15, 18:05

    typo3/sysext/scheduler/Classes/Controller/SchedulerModuleController.php:1090 $exception = @unserialize($schedulerRecord['lastexecution_failure']);
  10. Stephan Großberndt uploaded patch set 2 08/18/15, 18:51

  11. Markus Klein voted on patch set 2 CR +1 V +1 08/18/15, 19:14

  12. Wouter Wolters voted on patch set 2 CR +1 08/18/15, 19:16

  13. Daniel Goerz voted on patch set 2 CR +1 V +1 08/18/15, 19:22

  14. Markus Klein voted on patch set 2 CR +2 V +2 08/18/15, 22:22

  15. Markus Klein merged patch set 2 08/18/15, 22:23