Review main Merged

42723[FEATURE] Add new TS option getData->pagelayout

Benni Mack CR +2 V +2 Normal +68 −1 updated 09/19/15, 14:38

Commit message

Add a new TypoScript getData option to fetch the backend layout
of the current page, and if empty, use backend_layout_next_level.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Georg Ringer +1
  • Verified V +2
    • Christian Kuhn +2
    • Georg Ringer +1

Issues 1

Files 2

Review log 14

  1. Benni Mack uploaded patch set 1 08/18/15, 17:12

  2. Benni Mack commented on patch set 1 CR -1 08/18/15, 18:55

    Rst file still missing.
  3. Georg Ringer uploaded patch set 2 09/08/15, 06:44

  4. Georg Ringer uploaded patch set 3 09/08/15, 07:11

  5. Jo Hasenau commented on patch set 3 V -1 CR -1 09/09/15, 14:17

    Actually the backend_layout is assigned to a single page only and not inherited automatically. On the other hand backend layout next level is always inherited unless there is a value in backend_layout, which overrides it for that particular page. Still the children of that page might have the same inherited backend_layout_next_level. This is why checking for backend_layout should never be done with "slide". The order of the checkks must be: Check for backend_layout of the current page, if there is none, do a check for backend_layout_next_level with slide, if there is still none, use the default backend layout.
  6. Jo Hasenau uploaded patch set 4 09/09/15, 14:31

  7. Jo Hasenau uploaded patch set 5 09/09/15, 14:57

  8. Benni Mack commented on patch set 5 09/10/15, 06:49

    Hey Joey, we discussed in Slack if we do it the same way as in the Page Layout module. What do you think? for naming I'm fine with either way "pagelayout" / "backendlayout" or "currentlayout"
  9. Benni Mack uploaded patch set 6 09/14/15, 13:19

  10. Georg Ringer voted on patch set 6 CR +1 V +1 09/15/15, 10:49

  11. Christian Kuhn commented on patch set 6 CR +2 V +2 09/15/15, 12:16

    nice.
  12. Christian Kuhn merged patch set 6 09/15/15, 12:16

  13. Jo Hasenau commented on patch set 7 09/15/15, 19:20

    @Benni: Sorry - did not notice your last question. But the final version looks good anyway and it is merged - so thumbs up :-)
  14. Mathias Schreiber commented on patch set 7 09/19/15, 14:38

    Can we do a followup here to rename the key to "backendlayout" because now we have naming clashes with pages.layout?