Review main Merged

42764[BUGFIX] Add values to submit buttons

Wouter Wolters CR +2 V +2 Easy +14 −14 updated 08/20/15, 16:17

Commit message

Submit buttons need to have a value set,
otherwise submit checks in the PHP code won't work.

Some useless POST checks are removed after the removal of the
type=image input fields for saving data.

Review

  • Code review CR +2
    • Benjamin Kott +2
    • Markus Klein +1
  • Verified V +2
    • Benjamin Kott +2
    • Markus Klein +1

Issues 1

Files 5

Review log 9

  1. Wouter Wolters uploaded patch set 1 08/19/15, 17:27

  2. Daniel Goerz voted on patch set 1 CR +1 08/19/15, 21:09

  3. Alexander Opitz voted on patch set 1 V +1 CR +1 08/20/15, 08:09

  4. Frederic Gaus voted on patch set 1 CR +1 08/20/15, 08:23

  5. Georg Ringer voted on patch set 1 CR +1 V +1 08/20/15, 11:40

  6. Markus Klein uploaded patch set 2 08/20/15, 14:07

  7. Markus Klein commented on patch set 2 V +1 CR +1 08/20/15, 14:08

    This now makes the Constant editor working again.
  8. Benjamin Kott voted on patch set 2 CR +2 V +2 08/20/15, 16:17

  9. Benjamin Kott merged patch set 2 08/20/15, 16:17