Review main Merged

42767[BUGFIX] Show first tab in Element Wizard as fallback

Christian Seifert CR +2 V +2 Easy +9 −3 updated 08/21/15, 07:42

Commit message

Using the extension gridelements it is possible to restrict the
selectable content elements instead of the full menu configured
by TSconfig. At first, you might have 5 menus available and you
click on the last menu tab (maybe the fifth), so the backend
stores 5 as current tab.
Adding content elements within a gridelement, which restricts the
range of selectable CEs, you can only select the first tab (p.e.).
The original code assumes that the fifth tab is still there and
tries to select it.

This patch checks first against the existence of the selected tab.
If there is no "fifth" tab p.e. the index is set to 1.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Markus Klein +1
    • Jan Helke +1
  • Verified V +2
    • Wouter Wolters +2
    • Markus Klein +1
    • Jan Helke +1

Issues 1

Files 2

Review log 15

  1. Christian Seifert uploaded patch set 1 08/19/15, 23:06

  2. Markus Klein commented on patch set 1 08/20/15, 08:57

    The patch does not apply to current master. How did you create it?
  3. Christian Seifert uploaded patch set 2 08/20/15, 22:19

  4. Markus Klein commented on patch set 2 08/20/15, 22:46

    just a nitpick.

    tabmenu.js:31

    trailing space. pls configure your IDE to remove them automatically.
  5. Christian Seifert uploaded patch set 3 08/20/15, 23:01

  6. Markus Klein voted on patch set 3 CR +1 V +1 08/21/15, 06:58

  7. Wouter Wolters commented on patch set 3 CR -1 08/21/15, 07:01

    menues -> menus and you click
    restricts

    tabmenu.js:27

    concat with space around the + ?
  8. Markus Klein updated the commit message in patch set 4 08/21/15, 07:05

  9. Markus Klein commented on patch set 4 08/21/15, 07:05

    will push an update for the missing spaces
  10. Markus Klein commented on patch set 4 CR +1 V +1 08/21/15, 07:08

    Noticed that all other strings lack the inter-spaces as well. So fine with me.
  11. Jan Helke voted on patch set 4 CR +1 V +1 08/21/15, 07:14

  12. Wouter Wolters voted on patch set 4 V +2 CR +2 08/21/15, 07:16

  13. Wouter Wolters merged patch set 4 08/21/15, 07:16

  14. Wouter Wolters commented on patch set 5 08/21/15, 07:17

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 158913e10ba440d141fe75e6e2e01063312b9e29
  15. Markus Klein commented on patch set 5 08/21/15, 07:42

    PageLayoutController.php:553

    Wrong here... damn. Will push followup