42771[FEATURE] Multiline configuration fields in extension configuration
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 4
- typo3/sysext/core/Classes/TypoScript/ExtendedTemplateService.php+14 −5
- typo3/sysext/core/Documentation/Changelog/master/Feature-69202-AllowMultilineConfigurationFieldInExtensionManager.rst1new+21 −0
- typo3/sysext/extensionmanager/Classes/ViewHelpers/Form/TypoScriptConstantsViewHelper.php+23 −2
- typo3/sysext/extensionmanager/Resources/Private/Language/locallang.xlf+3 −0
Review log 20
-
Andreas Kienast uploaded patch set 1 08/20/15, 09:03
-
Jan Helke voted on patch set 1 CR +1 08/21/15, 09:23
-
Jan Helke voted on patch set 1 CR 0 08/21/15, 09:33
-
Jan Helke commented on patch set 1 08/21/15, 09:36
To me it seems that this patch does that not for the extension configuration in the EM but for the Constant Editor in the Template module. -
Jan Helke commented on patch set 1 08/21/15, 10:01
Reply
Ignore that last comment -
Jan Helke commented on patch set 1 CR -1 08/21/15, 10:04
Andy is working on it -
Andreas Kienast uploaded patch set 2 08/21/15, 10:13
-
Jan Helke commented on patch set 2 CR -1 08/21/15, 11:12
Andy is still working on it. -
Xavier Perseguers commented on patch set 2 CR -1 08/25/15, 06:27
Feature-69202-AllowMultilineConfigurationFieldInExtensionManager.rst:16missing new line before "code-block" -
Frank Nägler commented on patch set 2 CR +1 10/02/15, 11:45
on it and testing -
Frank Nägler uploaded patch set 3 10/02/15, 11:54
-
Frank Nägler voted on patch set 3 CR +1 V +1 10/02/15, 11:55
-
Andreas Kienast commented on patch set 3 CR -2 10/04/15, 06:07
Please give me a chance to test (and maybe adjust) this patch on current master, as the editing of multiline constants still had some issues. -
Oliver Hader uploaded patch set 4 10/09/15, 00:09
-
Benni Mack commented on patch set 4 04/04/16, 09:02
ping. -
Andreas Kienast commented on patch set 4 04/04/16, 09:03
I'll take a look at this patch again as soon as possible. -
Frank Nägler voted on patch set 4 CR +1 04/04/16, 11:09
-
Andreas Kienast uploaded patch set 5 04/04/16, 18:25
-
Andreas Kienast commented on patch set 5 CR 0 04/04/16, 18:28
I'll discontinue working on this patch. It's imho too much effort to rewrite the ExtendedTemplatedService for such a little feature. I'll lift my -2 and abandon the patch, in case somebody wants to work on this patch later. -
Andreas Kienast abandoned the change 04/04/16, 18:28