Review main Merged

42774[BUGFIX] avoid Call to a member function getValue() on a non-object

Ralf Zimmermann CR +2 V +2 Easy +5 −1 updated 08/29/15, 09:50

Commit message

Prevents calling a method of a non-existent object.

If an attribute is not set via Typoscript no object for the attribute
is instantiated. It must be checked if the attribute exists before
calling it.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Anja Leichsenring +1
    • Michael Oehlhof +1
  • Verified V +2
    • Andreas Kienast +2
    • Björn Jacob +1
    • Anja Leichsenring +1

Issues 1

Files 1

Review log 8

  1. Ralf Zimmermann uploaded patch set 1 08/20/15, 13:30

  2. Björn Jacob voted on patch set 1 V +1 08/28/15, 17:34

  3. Björn Jacob commented on patch set 1 08/28/15, 17:52

    Tested on both 7 and 6 master.
  4. Michael Oehlhof voted on patch set 1 CR +1 08/28/15, 18:35

  5. Anja Leichsenring voted on patch set 1 CR +1 V +1 08/29/15, 09:46

  6. Andreas Kienast voted on patch set 1 CR +2 V +2 08/29/15, 09:50

  7. Andreas Kienast merged patch set 1 08/29/15, 09:50

  8. Andreas Kienast commented on patch set 2 08/29/15, 09:50

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 2d6f4f633787e2c0ba283b8887d5dc48ce860a59