Review main Abandoned

42779[BUGFIX] Standardize element name properties

Ralf Zimmermann CR 0 V 0 Normal +172 −6 updated 09/18/15, 19:58

Commit message

A element name property definded by Typoscript may have different name
in the frontend. After submitting the form, the names from
Typoscript and the POST request can not be mapped.
This patch standardizes the names on both sides.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 7

Review log 20

  1. Ralf Zimmermann uploaded patch set 1 08/20/15, 16:51

  2. Benni Mack wrote 08/20/15, 17:03

    Topic set to EXT: form
  3. Daniel Goerz voted on patch set 1 CR +1 08/21/15, 21:46

  4. Björn Jacob voted on patch set 1 CR +1 V +1 08/29/15, 10:28

  5. Andreas Kienast voted on patch set 1 CR +1 08/29/15, 15:13

  6. Anja Leichsenring commented on patch set 1 CR -1 08/29/15, 16:57

    on it
  7. Anja Leichsenring uploaded patch set 2 08/29/15, 18:11

  8. Michael Oehlhof commented on patch set 2 08/29/15, 18:17

    TypoScriptFactoryTest.php:56

    Do you mean Reconstitutes ? (missing t between s and i)
  9. Michael Oehlhof voted on patch set 2 V +1 08/29/15, 18:21

  10. Anja Leichsenring uploaded patch set 3 08/30/15, 07:13

  11. Anja Leichsenring commented on patch set 3 08/30/15, 07:15

    true, typo fixed
  12. Anja Leichsenring voted on patch set 3 CR +1 V +1 08/30/15, 08:33

  13. Daniel Goerz voted on patch set 3 CR +1 08/30/15, 08:38

  14. Michael Oehlhof voted on patch set 3 CR +1 V +1 08/30/15, 09:31

  15. Björn Jacob voted on patch set 3 V +1 08/30/15, 13:43

  16. Oliver Hader commented on patch set 3 08/30/15, 13:53

    Validation names should be considered as well, I guess...
  17. Oliver Hader uploaded patch set 4 08/30/15, 14:17

  18. Oliver Hader voted on patch set 4 CR +1 V +1 08/30/15, 14:19

  19. Oliver Hader commented on patch set 4 CR -1 08/30/15, 14:28

    Seems like filters need to be considered as well...
  20. Benni Mack abandoned the change 09/18/15, 19:58

    this is fixed in v7.