42779[BUGFIX] Standardize element name properties
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 7
- typo3/sysext/form/Classes/Domain/Factory/TypoScriptFactory.php+3 −1
- typo3/sysext/form/Classes/Domain/Model/Attribute/NameAttribute.php+3 −4
- typo3/sysext/form/Classes/Utility/FormUtility.php+20 −0
- typo3/sysext/form/Classes/Utility/ValidatorUtility.php+2 −1
- typo3/sysext/form/Classes/Request.php+8 −0
- typo3/sysext/form/Tests/Unit/Domain/Factory/TypoScriptFactoryTest.php1+81 −0
- typo3/sysext/form/Tests/Unit/Domain/Model/Attribute/NameAttributeTest.phpnew+55 −0
Review log 20
-
Ralf Zimmermann uploaded patch set 1 08/20/15, 16:51
-
Benni Mack wrote 08/20/15, 17:03
Topic set to EXT: form -
Daniel Goerz voted on patch set 1 CR +1 08/21/15, 21:46
-
Björn Jacob voted on patch set 1 CR +1 V +1 08/29/15, 10:28
-
Andreas Kienast voted on patch set 1 CR +1 08/29/15, 15:13
-
Anja Leichsenring commented on patch set 1 CR -1 08/29/15, 16:57
on it -
Anja Leichsenring uploaded patch set 2 08/29/15, 18:11
-
Michael Oehlhof commented on patch set 2 08/29/15, 18:17
TypoScriptFactoryTest.php:56Do you mean Reconstitutes ? (missing t between s and i) -
Michael Oehlhof voted on patch set 2 V +1 08/29/15, 18:21
-
Anja Leichsenring uploaded patch set 3 08/30/15, 07:13
-
Anja Leichsenring commented on patch set 3 08/30/15, 07:15
true, typo fixed -
Anja Leichsenring voted on patch set 3 CR +1 V +1 08/30/15, 08:33
-
Daniel Goerz voted on patch set 3 CR +1 08/30/15, 08:38
-
Michael Oehlhof voted on patch set 3 CR +1 V +1 08/30/15, 09:31
-
Björn Jacob voted on patch set 3 V +1 08/30/15, 13:43
-
Oliver Hader commented on patch set 3 08/30/15, 13:53
Validation names should be considered as well, I guess... -
Oliver Hader uploaded patch set 4 08/30/15, 14:17
-
Oliver Hader voted on patch set 4 CR +1 V +1 08/30/15, 14:19
-
Oliver Hader commented on patch set 4 CR -1 08/30/15, 14:28
Seems like filters need to be considered as well... -
Benni Mack abandoned the change 09/18/15, 19:58
this is fixed in v7.