42804[!!!][BUGFIX] Fix wrong usage of Enum in InformationStatus Enum itself
Commit message
Review
-
Code review CR +2
- Sascha Egerer +2
- Daniel Goerz +1
- Anja Leichsenring +1
-
Verified V +2
- Sascha Egerer +2
- Daniel Goerz +1
- Anja Leichsenring +1
Issues 1
Files 3
- typo3/sysext/backend/Classes/Backend/ToolbarItems/SystemInformationToolbarItem.php1+9 −5
- typo3/sysext/backend/Classes/Toolbar/Enumeration/InformationStatus.php2+8 −9
- typo3/sysext/core/Documentation/Changelog/7.5/Breaking-69224-FixWrongUsageOfEnumerationsInInformationStatusmapStatusToInt.rstnew+21 −0
Review log 17
-
Sascha Egerer uploaded patch set 1 08/21/15, 09:08
-
Sascha Egerer commented on patch set 1 CR -1 08/21/15, 09:35
Update is coming -
Sascha Egerer uploaded patch set 2 08/21/15, 09:38
-
Andreas Kienast updated the commit message in patch set 3 08/21/15, 09:42
-
Mathias Brodala commented on patch set 3 CR -1 08/21/15, 09:43
SystemInformationToolbarItem.php:95Please use the expected value explicitly here. -
Sascha Egerer uploaded patch set 4 08/21/15, 09:45
-
Mathias Brodala commented on patch set 4 08/21/15, 09:59
InformationStatus.php:67I think these two must be swapped aka $this->isGreaterThan($that). -
Sascha Egerer commented on patch set 4 08/26/15, 06:40
InformationStatus.php:67ReplyOh yes, thats correct. -
Sascha Egerer uploaded patch set 5 08/26/15, 06:41
-
Daniel Goerz commented on patch set 5 08/27/15, 17:59
Maybe add a rst with a short description what actually might break here? -
Sascha Egerer uploaded patch set 6 09/21/15, 10:47
-
Anja Leichsenring uploaded patch set 7 09/24/15, 05:25
-
Anja Leichsenring voted on patch set 7 CR +1 V +1 09/24/15, 05:25
-
Daniel Goerz voted on patch set 7 CR +1 V +1 09/24/15, 21:52
-
Sascha Egerer voted on patch set 7 CR +2 V +2 09/25/15, 05:54
-
Sascha Egerer merged patch set 7 09/25/15, 05:54
-
Helmut Hummel commented on patch set 8 09/25/15, 05:56
Thank you very much for this fix!