Review main Merged Breaking

42804[!!!][BUGFIX] Fix wrong usage of Enum in InformationStatus Enum itself

Sascha Egerer CR +2 V +2 Normal +38 −14 updated 09/25/15, 05:56

Commit message

The Enumeration implementation of InformationStatus provides
a mapStatusToInt() method that must expect a InformationStatus instance
as parameter instead of a string.

The method mapStatusToInt() has also been replaced by "isGreaterThan" as
a comparison method fits better into the enumeration usage.

This change is breaking but should not really break anything as it
was introduced in 7.4 and only used at one place in the core.

Review

  • Code review CR +2
    • Sascha Egerer +2
    • Daniel Goerz +1
    • Anja Leichsenring +1
  • Verified V +2
    • Sascha Egerer +2
    • Daniel Goerz +1
    • Anja Leichsenring +1

Issues 1

Files 3

Review log 17

  1. Sascha Egerer uploaded patch set 1 08/21/15, 09:08

  2. Sascha Egerer commented on patch set 1 CR -1 08/21/15, 09:35

    Update is coming
  3. Sascha Egerer uploaded patch set 2 08/21/15, 09:38

  4. Andreas Kienast updated the commit message in patch set 3 08/21/15, 09:42

  5. Mathias Brodala commented on patch set 3 CR -1 08/21/15, 09:43

    SystemInformationToolbarItem.php:95

    Please use the expected value explicitly here.
  6. Sascha Egerer uploaded patch set 4 08/21/15, 09:45

  7. Mathias Brodala commented on patch set 4 08/21/15, 09:59

    InformationStatus.php:67

    I think these two must be swapped aka $this->isGreaterThan($that).
  8. Sascha Egerer commented on patch set 4 08/26/15, 06:40

    InformationStatus.php:67 Reply

    Oh yes, thats correct.
  9. Sascha Egerer uploaded patch set 5 08/26/15, 06:41

  10. Daniel Goerz commented on patch set 5 08/27/15, 17:59

    Maybe add a rst with a short description what actually might break here?
  11. Sascha Egerer uploaded patch set 6 09/21/15, 10:47

  12. Anja Leichsenring uploaded patch set 7 09/24/15, 05:25

  13. Anja Leichsenring voted on patch set 7 CR +1 V +1 09/24/15, 05:25

  14. Daniel Goerz voted on patch set 7 CR +1 V +1 09/24/15, 21:52

  15. Sascha Egerer voted on patch set 7 CR +2 V +2 09/25/15, 05:54

  16. Sascha Egerer merged patch set 7 09/25/15, 05:54

  17. Helmut Hummel commented on patch set 8 09/25/15, 05:56

    Thank you very much for this fix!