Review TYPO3_4-3 Merged

4283[BUGFIX] Maintain compatibility with changed headline rendering

Oliver Hader CR +2 V +2 Normal +96 −1 updated 06/03/13, 20:49

Commit message

If the fontTag property is set and the dataWrap property is set to the
default value, replace the dataWrap with the fontTag property value and
disable insertData on this level (if set).

This is to retain compatibility with versions before 4.5.4 while
compatibility with modified templates (before and after 4.5.4) is still
provided.

Review

  • Code review CR +2
    • Michael Stucki +2
    • Oliver Hader +1
  • Verified V +2
    • Michael Stucki +2
    • Oliver Hader +1

Issues 2

Files 2

Review log 4

  1. Michael Stucki commented on patch set 1 V 0 08/12/11, 16:30

    by team member; Looks good to me, approved
  2. Oliver Hader commented on patch set 1 08/12/11, 16:30

    Should read "except" instead of "instead"... (confused now? *g*)
  3. Oliver Hader commented on patch set 1 08/12/11, 16:30

    Verified; Looks good to me, but someone else must approve Instead of unit-tests this is 100% back port from TYPO3_4-4
  4. Oliver Hader merged patch set 1 08/12/11, 16:30