Review main Merged

42842[FEATURE] Make the image quality definable per sourceCollection

Christian Seifert CR +2 V +2 Easy +39 −0 updated 09/04/15, 06:20

Commit message

At the moment the image quality of generated jpegs is configured
centrally in LocalConfiguration. Due to trying to find a balance
between image size and image quality it might be useful to enable
the configuration of the image quality for each sourceCollection
entry.

The change set enables users to p.e. render normal images with 90%
and retina images with p.e. 70%. To optionally enable the "quality"
setting for a sourceCollection, TypoScript can be configured as
followed (as example):
tt_content.image.20.1.sourceCollection.smallRetina.quality = 70

If not set, TYPO3 will take the default one of LocalConfiguration.

Review

  • Code review CR +2
    • Alexander Opitz +2
    • Markus Klein +1
  • Verified V +2
    • Alexander Opitz +2
    • Markus Klein +1

Issues 1

Files 2

Review log 14

  1. Christian Seifert uploaded patch set 1 08/22/15, 21:19

  2. Wouter Wolters commented on patch set 1 08/25/15, 18:46

    Features can only go into master branch and needs an RST file to describe the future. See folder sysext/core/Documentation/ I'm not into this logic too much. Please ask on Slack if this is a wanted change.
  3. Christian Seifert uploaded patch set 2 08/26/15, 22:29

  4. Markus Klein commented on patch set 2 08/26/15, 22:42

    Feature-59591-IntroducedQualityParameterInSourceCollection.rst:8

    This is intended for inclusion into the official documentation, hence this should be written in an appropriate way. Phrases like "at the moment" are not fitting for this purpose. Please read the text like you would read it in the docs.

    ContentObjectRenderer.php:1611

    please check also this with isset()
  5. Christian Seifert uploaded patch set 3 08/27/15, 17:56

  6. Markus Klein uploaded patch set 4 08/27/15, 18:47

  7. Markus Klein commented on patch set 4 CR +1 08/27/15, 18:47

    I slightly adjusted the code for correct stdWrap detection.
  8. Markus Klein voted on patch set 4 V +1 08/27/15, 21:45

  9. Wouter Wolters commented on patch set 4 08/28/15, 18:41

    Feature-59591-ImageQualityDefinablePerSourceCollection.rst:29

    stays as it is.
  10. Christian Seifert uploaded patch set 5 08/29/15, 15:31

  11. Markus Klein updated the commit message in patch set 6 09/03/15, 23:12

  12. Markus Klein voted on patch set 6 CR +1 V +1 09/03/15, 23:14

  13. Alexander Opitz voted on patch set 6 V +2 CR +2 09/04/15, 06:20

  14. Alexander Opitz merged patch set 6 09/04/15, 06:20