42849[FEATURE] New option to disable the age display of dates per field by TCA
Commit message
Review
-
Code review CR +2
- Philipp Gampe +2
- matseriks +1
- Anja Leichsenring +1
-
Verified V +2
- Philipp Gampe +2
- matseriks +1
- Anja Leichsenring +1
Issues 1
Files 3
Review log 16
-
Christian Seifert uploaded patch set 1 08/23/15, 18:39
-
Stefan Neufeind commented on patch set 1 CR -1 08/23/15, 21:22
imho let's first get the timezones straight (proper timezone-handling). Afaik it was an accepted feature for 7 LTS. Issue for timezone-handling: https://forge.typo3.org/issues/61110 -
Christian Seifert commented on patch set 1 08/23/15, 22:08
Hi Stefan, the change set is about displaying the age calculation of a single record within record listing in web_list. It is not about calculating the age. It's just about to suppress displaying it, when only the date value shall be shown (p.e. "2015-08-23" instead of "2015-08-23 (-2 days)") -
Stefan Neufeind commented on patch set 1 08/23/15, 23:28
Oh, sorry i misunderstood it. Well, then lets see. Since it's a feature, please add the long explanation into an RST-file. (The generator at https://forger.typo3.org/standard/rst might help you.) Besides that, shouldn't this maybe be a setting per field? And I wonder if we would usually do it via TCA - so the integrator would create a small existension that provides a tiny TCA-override.BackendUtility.php:2411imho we'd usually just check for empty() in this case - or cast to (bool) (then together with isset) imho -
Philipp Gampe commented on patch set 1 08/24/15, 12:54
+1 for setting per field +1 to make this configurable from TCA only -
Christian Seifert commented on patch set 1 08/25/15, 21:28
Thanks for your replies, ideas and points. Breaking it down to fields is more advanced and the next change set will respect that. I'm not sure, if TCA is the right place for it, because the main motivation is to suppress displaying the calculation (which eval "date" actually does not reveal). The question is how to design the new option being available in the TCA config. What about re-using "format"? If set, it will be used. If not set, the date is rendered as it is now (to avoid breaking changes). A solution like "is_in" would be another option, but would results in an not so nice design (matters only, when eval is set to date). -
Christian Seifert uploaded patch set 2 08/30/15, 10:51
-
Anja Leichsenring uploaded patch set 3 08/30/15, 18:57
-
Anja Leichsenring commented on patch set 3 CR +1 V +1 08/30/15, 18:58
added tests, found a bug in the concatination of the string (no label would be applied) and improved the condition. -
Anja Leichsenring commented on patch set 3 CR -1 08/30/15, 19:01
made a mistake with the label again, working on it. -
Anja Leichsenring uploaded patch set 4 08/30/15, 19:09
-
Anja Leichsenring uploaded patch set 5 08/30/15, 19:10
-
Anja Leichsenring voted on patch set 5 CR +1 V +1 08/30/15, 19:11
-
matseriks voted on patch set 5 CR +1 V +1 08/31/15, 07:00
-
Philipp Gampe voted on patch set 5 CR +2 V +2 08/31/15, 19:20
-
Philipp Gampe merged patch set 5 08/31/15, 19:20