Review main Merged

42864[BUGFIX] Prevent search upload folder in write protected storages

Nicole Hummel CR +2 V +2 Easy +10 −8 updated 09/05/15, 20:46

Commit message

If a storage is marked as non-writeable there isn't any possibility to
have an upload folder in there. So this storage should be skipped in the
lookup of the default upload folder of an user.

Review

  • Code review CR +2
    • Philipp Gampe +2
    • Wouter Wolters +1
    • Frans Saris +1
    • Morton Jonuschat +1
    • Andreas Kienast +1
    • Nicole Hummel +1
  • Verified V +2
    • Philipp Gampe +2
    • Morton Jonuschat +1
    • Nicole Hummel +1

Issues 1

Files 1

Review log 12

  1. Nicole Hummel uploaded patch set 1 08/25/15, 10:10

  2. Frans Saris commented on patch set 1 CR +1 08/25/15, 11:47

    BackendUserAuthentication.php:1790

    Does it make sense to add the same check here? if ($storage->isDefault() && $storage->isWritable()) {
  3. Philipp Gampe commented on patch set 1 CR +1 08/25/15, 12:08

    BackendUserAuthentication.php:1790 Reply

    I would say so too.
  4. Morton Jonuschat uploaded patch set 2 08/28/15, 09:41

  5. Morton Jonuschat voted on patch set 2 CR +1 V +1 08/28/15, 09:54

  6. Nicole Hummel commented on patch set 2 CR +1 V +1 08/28/15, 11:44

    Thank you Morton!
  7. Wouter Wolters voted on patch set 2 CR +1 08/28/15, 18:14

  8. Frans Saris voted on patch set 2 CR +1 08/29/15, 08:44

  9. Andreas Kienast voted on patch set 2 CR +1 08/29/15, 15:35

  10. Philipp Gampe voted on patch set 2 CR +2 V +2 09/05/15, 20:46

  11. Philipp Gampe merged patch set 2 09/05/15, 20:46

  12. Philipp Gampe commented on patch set 3 09/05/15, 20:46

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 49dcaa87b2d1361c059eff79a7dbfa1a7c3d871a