Review main Merged

42880[TASK] Update to phpunit 4.8

Anja Leichsenring CR +2 V +2 Normal +99 −98 updated 08/26/15, 10:19

Commit message

Review

  • Code review CR +2
    • Markus Klein +2
    • Christian Kuhn +2
    • Alexander Opitz +1
  • Verified V +2
    • Markus Klein +2
    • Christian Kuhn +2
    • Alexander Opitz +1

Issues 1

Files 2

Review log 11

  1. Anja Leichsenring uploaded patch set 1 08/26/15, 09:36

  2. Alexander Opitz commented on patch set 1 08/26/15, 09:42

    This composer.lock also updates other packages. By accident?
  3. Christian Kuhn voted on patch set 1 CR +1 V +1 08/26/15, 09:45

  4. Alexander Opitz commented on patch set 1 CR -1 08/26/15, 09:47

    Works with PHP5.6 and PHP7(master-branch) But this patch do not only update phpunit.
  5. Anja Leichsenring commented on patch set 1 08/26/15, 09:55

    yes, it updates dependencies and other testing tools as well. This is wanted and needed.
  6. Markus Klein voted on patch set 1 CR +2 V +2 08/26/15, 10:17

  7. Christian Kuhn voted on patch set 1 CR +2 V +2 08/26/15, 10:17

  8. Christian Kuhn commented on patch set 1 08/26/15, 10:18

    these updates are ok and testing related only ...
  9. Alexander Opitz voted on patch set 1 V +1 CR +1 08/26/15, 10:18

  10. Alexander Opitz merged patch set 1 08/26/15, 10:18

  11. Alexander Opitz commented on patch set 2 08/26/15, 10:19

    Merged, beside that the commit message hides all the other updates, which is not cool.