Review main Merged

42885[BUGFIX] Correctly treat relative date specification in date-VH

Markus Klein CR +2 V +2 Easy +10 −1 updated 01/09/19, 20:56

Commit message

If now base time is given, a relative date must be based on the current time.
A wrong check is fixed to make this working again.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Daniel Goerz +1
    • Josef Glatz +1
    • Stephan Großberndt +1
  • Verified V +2
    • Andreas Kienast +2
    • Daniel Goerz +1
    • Josef Glatz +1

Issues 2

Files 2

Review log 8

  1. Markus Klein uploaded patch set 1 08/26/15, 21:47

  2. Daniel Goerz commented on patch set 1 08/26/15, 21:53

    DateViewHelperTest.php:151

    I dont like names for test methods that dont tell you what they test.
  3. Markus Klein uploaded patch set 2 08/26/15, 21:58

  4. Daniel Goerz voted on patch set 2 V +1 CR +1 08/26/15, 22:01

  5. Stephan Großberndt commented on patch set 2 CR +1 08/26/15, 22:08

    Thanks for the fast fix
  6. Andreas Kienast voted on patch set 2 CR +2 V +2 08/27/15, 06:25

  7. Andreas Kienast merged patch set 2 08/27/15, 06:25

  8. Josef Glatz voted on patch set 2 CR +1 V +1 01/09/19, 20:56