Review main Merged

42889[BUGFIX] Properly nest added FlexFormSectionContainer

Andreas Kienast CR +2 V +2 Easy +11 −9 updated 08/28/15, 18:06

Commit message

Attach new created FlexFormSectionContainer to the right element.
Additionally, event stacking has been resolved.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Daniel Goerz +1
    • Morton Jonuschat +1
  • Verified V +2
    • Wouter Wolters +2
    • Daniel Goerz +1
    • Morton Jonuschat +1

Issues 1

Files 3

Review log 8

  1. Andreas Kienast uploaded patch set 1 08/27/15, 13:10

  2. Anja Leichsenring voted on patch set 1 CR +1 V +1 08/27/15, 17:09

  3. Markus Klein commented on patch set 1 08/27/15, 18:50

    FormEngineFlexForm.js:71

    can you please add a comment why we need this off() here and below. that is not clear by reading to me.
  4. Andreas Kienast uploaded patch set 2 08/28/15, 15:00

  5. Daniel Goerz voted on patch set 2 CR +1 V +1 08/28/15, 15:17

  6. Morton Jonuschat voted on patch set 2 CR +1 V +1 08/28/15, 17:56

  7. Wouter Wolters voted on patch set 2 V +2 CR +2 08/28/15, 18:06

  8. Wouter Wolters merged patch set 2 08/28/15, 18:06