Review main Merged

42962[FEATURE] Show tt_content preview in page module via Fluid

Benni Mack CR +2 V +2 Normal +60 −0 updated 09/09/15, 06:50

Commit message

A new option via TSconfig allows to render tt_content elements via Fluid
in the Backend.

Example:
mod.web_layout.tt_content.preview.media = EXT:site_mysite/Resources/Private/Templates/Preview/Media.html

All values from the tt_content record are available as content elements.

Review

  • Code review CR +2
    • Alexander Opitz +2
    • Daniel Goerz +1
  • Verified V +2
    • Alexander Opitz +2
    • Daniel Goerz +1

Issues 1

Files 2

Review log 14

  1. Benni Mack uploaded patch set 1 09/01/15, 17:53

  2. Wouter Wolters commented on patch set 1 09/01/15, 18:13

    PageLayoutView.php:1364

    space after catch

    Feature-69459-ShowTt_contentPreviewInPageModuleViaFluid.rst:12

    I never saw a block like this, and also our forger tool only lists typoscript as code block option. Please check with documentation team
  3. Daniel Goerz commented on patch set 1 09/01/15, 19:26

    I dont understand that sentence. Did you mean "All properties of the tt_content record are available in the template directly." from the .rst file?

    PageLayoutView.php:1359

    use statement here and maybe even for the exception below.
  4. Helmut Hummel commented on patch set 1 09/01/15, 20:16

    PageLayoutView.php:1364 Reply

    we should imho catch any exception here, as it would break the edit view completely otherwise
  5. Alexander Opitz commented on patch set 1 09/03/15, 07:33

    IMHO this will mostly used in PlugIns, which often have a Flexform. Can I access this Flexform with Fluid?
  6. Benni Mack commented on patch set 1 09/03/15, 21:55

    @spelunkenalex: yes. you can access the flexform via {pi_flexform} and do whatever you want :)
  7. Georg Ringer uploaded patch set 2 09/08/15, 04:57

  8. Alexander Opitz commented on patch set 2 09/08/15, 06:06

    PageLayoutView.php:1372

    Space after catch
  9. Alexander Opitz uploaded patch set 3 09/08/15, 06:09

  10. Alexander Opitz commented on patch set 2 09/08/15, 06:09

    PageLayoutView.php:1372 Reply

    Done
  11. Alexander Opitz voted on patch set 3 CR +1 09/08/15, 07:35

  12. Daniel Goerz commented on patch set 3 CR +1 V +1 09/08/15, 18:39

    Nice little feature. I added an extension to the ticket so you can verify this is working.
  13. Alexander Opitz voted on patch set 3 V +2 CR +2 09/09/15, 06:50

  14. Alexander Opitz merged patch set 3 09/09/15, 06:50