42971[BUGFIX] Abstract XSD generator can handle more than two namespace parts
Commit message
Review
-
Code review CR +2
- Nicole Hummel +2
- Markus Klein +1
-
Verified V +2
- Nicole Hummel +2
- Markus Klein +1
Issues 1
Files 1
Review log 10
-
Helmut Hummel uploaded patch set 1 09/01/15, 20:11
-
Markus Klein commented on patch set 1 09/01/15, 20:21
deserves a simple unit test IMHOAbstractGenerator.php:81please add the comment again why this is -10 -
Helmut Hummel commented on patch set 1 09/02/15, 05:53
AbstractGenerator.php:74see comment here what the goal of this method isAbstractGenerator.php:81Replythe -10 is to strip off "ViewHelper" from the end. It was there a few lines below. I only moved it here, as it makes more sense to just strip in once. This line strips off the namespace from the beginning and "ViewHelper" from the end of the class name, leaving "Form\Select" from "TYPO3\CMS\Fluid\ViewHelpers\Form\SelectViewHelper" This is then transformed to "form.select" below -
Helmut Hummel commented on patch set 1 09/02/15, 05:57
AbstractGenerator.php:81ReplyDone -
Helmut Hummel uploaded patch set 2 09/02/15, 05:58
-
Markus Klein voted on patch set 2 CR +1 V +1 09/02/15, 06:49
-
Nicole Hummel voted on patch set 2 CR +2 V +2 09/02/15, 07:41
-
Nicole Hummel merged patch set 2 09/02/15, 07:41
-
Nicole Hummel commented on patch set 3 09/02/15, 07:41
Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit cc5d7dd9a330204bd21e6049ead690314698ce9e -
Helmut Hummel commented on patch set 3 09/02/15, 07:50
Thanks!