Review main Merged

42982[BUGFIX] Streamline Unit Tests for GeneralUtility::sanitizeLocalUrl

Nicole Hummel CR +2 V +2 Easy +0 −0 updated 09/03/15, 06:24

Commit message

Currently the Unit Tests for the function just work by accident. As
HTTP_HOST an absolute path is set which is used to get some other values
to compare the given strings. To add further tests we should streamline
the tests and set/add expectations for host and script_name.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Markus Klein +1
    • Wouter Wolters +1
    • Frans Saris +1
  • Verified V +2
    • Helmut Hummel +2
    • Wouter Wolters +1

Issues 1

Files 1

Review log 8

  1. Nicole Hummel uploaded patch set 1 09/02/15, 13:06

  2. Markus Klein commented on patch set 1 09/02/15, 14:28

    GeneralUtilityTest.php:2062

    you need to flush the getIndpEnv() cache each time
  3. Nicole Hummel uploaded patch set 2 09/02/15, 14:45

  4. Markus Klein voted on patch set 2 CR +1 09/02/15, 15:29

  5. Wouter Wolters voted on patch set 2 V +1 CR +1 09/02/15, 16:43

  6. Frans Saris voted on patch set 2 CR +1 09/02/15, 16:56

  7. Helmut Hummel voted on patch set 2 CR +2 V +2 09/03/15, 06:23

  8. Helmut Hummel merged patch set 2 09/03/15, 06:24