Review TYPO3_6-2 Merged

42988[BUGFIX] Streamline Unit Tests for GeneralUtility::sanitizeLocalUrl

Helmut Hummel CR +2 V +2 Easy +0 −0 updated 09/03/15, 06:48

Commit message

Currently the Unit Tests for the function just work by accident. As
HTTP_HOST an absolute path is set which is used to get some other values
to compare the given strings. To add further tests we should streamline
the tests and set/add expectations for host and script_name.

Review

  • Code review CR +2
    • Nicole Hummel +2
    • Helmut Hummel +1
  • Verified V +2
    • Nicole Hummel +2
    • Helmut Hummel +1

Issues 1

Files 1

Review log 4

  1. Helmut Hummel uploaded patch set 1 09/03/15, 06:34

  2. Helmut Hummel voted on patch set 1 CR +1 V +1 09/03/15, 06:44

  3. Nicole Hummel voted on patch set 1 CR +2 V +2 09/03/15, 06:48

  4. Nicole Hummel merged patch set 1 09/03/15, 06:48