Review main Merged

42997[CLEANUP] Streamline toggle search toolbox

Andreas Kienast CR +2 V +2 Normal +33 −22 updated 09/03/15, 13:50

Commit message

Remove the toggle functionality from the HTML template and use
jQuery + require.js for page and list.

Review

  • Code review CR +2
    • Markus Klein +2
    • Andreas Kienast +2
    • Alexander Opitz +1
  • Verified V +2
    • Markus Klein +2
    • Andreas Kienast +2
    • Alexander Opitz +1

Issues 1

Files 5

Review log 12

  1. Andreas Kienast uploaded patch set 1 09/03/15, 13:08

  2. Andreas Kienast uploaded patch set 2 09/03/15, 13:09

  3. Markus Klein commented on patch set 2 CR -1 09/03/15, 13:21

    PageLayoutController.php:1082

    There is API for that! pageRenderer->loadRequireJSModule()

    PageLayoutController.php:1083

    needs t3-js prefix

    toggleSearchToolbox.js:14

    must be within onready()
  4. Markus Klein commented on patch set 2 09/03/15, 13:24

    toggleSearchToolbox.js:13

    Uppercase T
  5. Alexander Opitz commented on patch set 2 V +1 CR -1 09/03/15, 13:30

    As Markus already noted
  6. Andreas Kienast uploaded patch set 3 09/03/15, 13:42

  7. Markus Klein voted on patch set 3 CR +1 09/03/15, 13:47

  8. Alexander Opitz voted on patch set 3 V +1 CR +1 09/03/15, 13:47

  9. Markus Klein voted on patch set 3 V +1 09/03/15, 13:49

  10. Markus Klein voted on patch set 3 CR +2 V +2 09/03/15, 13:49

  11. Andreas Kienast voted on patch set 3 CR +2 V +2 09/03/15, 13:49

  12. Andreas Kienast merged patch set 3 09/03/15, 13:50