Review main Merged

42999[TASK] Auto focus search field in content search

Andreas Kienast CR +2 V +2 Easy +6 −1 updated 09/03/15, 21:24

Commit message

After enabling the content search (in Page / List module), the search field
is automatically focused.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Markus Klein +1
  • Verified V +2
    • Wouter Wolters +2
    • Markus Klein +1

Issues 1

Files 1

Review log 7

  1. Andreas Kienast uploaded patch set 1 09/03/15, 15:29

  2. Markus Klein commented on patch set 1 09/03/15, 15:32

    ToggleSearchToolbox.js:21

    the field even has an ID, shouldn't we use that?
  3. Andreas Kienast uploaded patch set 2 09/03/15, 15:42

  4. Markus Klein uploaded patch set 3 09/03/15, 15:59

  5. Markus Klein voted on patch set 3 CR +1 V +1 09/03/15, 15:59

  6. Wouter Wolters voted on patch set 3 V +2 CR +2 09/03/15, 21:23

  7. Wouter Wolters merged patch set 3 09/03/15, 21:24