Review main Abandoned

43004[FEATURE] Add dynamic parameters to Backend Routes

Benni Mack CR 0 V 0 Hard +236 −24 updated 03/05/16, 19:36

Commit message

This is a missing piece from the introduction of Backend Routes,
allowing routes to use dynamic parameters in the routing URL,
by adding a RouteCompiler and a regular expression resolver.

The Record History route is using this logic now.

Review

  • Code review CR 0
  • Verified V 0

Files 9

Review log 12

  1. Benni Mack uploaded patch set 1 09/03/15, 21:26

  2. Benni Mack uploaded patch set 2 09/03/15, 21:39

  3. Philipp Gampe commented on patch set 2 09/05/15, 16:26

    AbstractController.php:40

    would prefer an interface here (if such exists)

    AbstractController.php:79

    I would like to have an own service for this (comming from Fluid) that takes controller, action, format and base path and calculates and sets everything accordingly. Might even be just one method of the view, but would come in handy in other locations as well.
  4. Benni Mack commented on patch set 2 09/10/15, 05:33

    AbstractController.php:40 Reply

    yes. but it's currently coupled to Extbase, so once we have a Fluid standalone package, we use the interface from there.
  5. Andreas Kienast commented on patch set 2 09/10/15, 14:17

    Those might be some stupid questions, I just want to make sure I understood the routing so far :)

    AbstractController.php:60

    Shouldn't come that from $route->getOption('controller')?

    AbstractController.php:61

    Separator must be \ (namespace and stuff)
  6. Stefan Froemken uploaded patch set 3 09/16/15, 12:20

  7. Stefan Froemken uploaded patch set 4 09/16/15, 13:12

  8. Stefan Froemken uploaded patch set 5 09/16/15, 13:46

  9. Benni Mack uploaded patch set 6 10/08/15, 18:52

  10. Benni Mack wrote 10/08/15, 18:54

    Topic set to EntryPoints
  11. Oliver Hader uploaded patch set 7 10/08/15, 23:55

  12. Benni Mack abandoned the change 03/05/16, 19:36

    after evaluating this a bit more, I come to the conclusion that if we introduce this stuff (as a feature) we need comileable routing otherwise this will be a huge performance drain. I think we should just simply use a third-party-library for this magic at a later point. I will abandon this patch therefore.