Review main Merged

43040[FEATURE] Scheduler: Add task to optimize MySQL tables

Morton Jonuschat CR +2 V +2 Hard +253 −0 updated 09/09/15, 09:44

Commit message

A scheduler task to run the ``OPTIMIZE TABLE`` command on selected
database tables has been added. The ``OPTIMIZE TABLE`` command
reorganizes the physical storage of table data and associated index
data to reduce storage space and improve I/O efficiency.

The scheduler task only shows database tables with storage engines
that support the ``OPTIMIZE TABLE`` command.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Georg Ringer +1
  • Verified V +2
    • Christian Kuhn +2
    • Georg Ringer +1

Issues 1

Files 5

Review log 9

  1. Morton Jonuschat uploaded patch set 1 09/04/15, 18:46

  2. Mathias Brodala commented on patch set 1 09/07/15, 07:41

    Would you mind implementing this as Extbase CommandController so that one can alternatively do this via CLI?
  3. Morton Jonuschat commented on patch set 1 09/07/15, 11:48

    How do I combine the AddtionalFieldProvider for the Table Multi-Select with the CommandController?
  4. Mathias Brodala commented on patch set 1 09/07/15, 11:52

    My bad, this is not possible with the CommandController API, forget about this.
  5. Wouter Wolters commented on patch set 1 09/07/15, 11:52

    OptimizeDatabaseTableAdditionalFieldProvider.php:99

    strict type checking for in_array please
  6. Georg Ringer uploaded patch set 2 09/07/15, 19:41

  7. Georg Ringer voted on patch set 2 CR +1 V +1 09/09/15, 04:12

  8. Christian Kuhn voted on patch set 2 CR +2 V +2 09/09/15, 09:44

  9. Christian Kuhn merged patch set 2 09/09/15, 09:44