43059[FEATURE] Trigger metadata extraction after file upload
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Wouter Wolters +1
-
Verified V +2
- Georg Ringer +2
- Wouter Wolters +1
Issues 1
Files 6
- typo3/sysext/core/Classes/Resource/Index/Indexer.php+42 −19
- typo3/sysext/core/Classes/Resource/ResourceStorage.php2+21 −0
- typo3/sysext/core/Configuration/TCA/sys_file_storage.php+10 −2
- typo3/sysext/core/Documentation/Changelog/master/Feature-56726-TriggerMetadataExtractionAfterFileUpload.rst3new+20 −0
- typo3/sysext/core/ext_tables.sql+1 −0
- typo3/sysext/lang/locallang_tca.xlf+3 −0
Review log 18
-
Frans Saris uploaded patch set 1 09/05/15, 20:08
-
Frans Saris commented on patch set 1 09/05/15, 20:24
This can easily be tested with any metadata extractor found in TER or https://review.typo3.org/#/c/41800 (add a youtube video and check if title, author, width and height are set) -
Philipp Gampe voted on patch set 1 CR +1 09/05/15, 21:03
-
Philipp Gampe commented on patch set 1 V -1 CR -1 09/05/15, 21:17
ResourceStorage.php:1219what is this? -
Frans Saris commented on patch set 1 09/05/15, 21:39
ResourceStorage.php:1219Replycool new stuff from another patch :) will push a new patch -
Frans Saris uploaded patch set 2 09/05/15, 21:44
-
Philipp Gampe voted on patch set 2 CR +1 09/05/15, 21:47
-
Philipp Gampe commented on patch set 2 09/06/15, 00:25
can't test, because meta extraction is broken for me, including indexing and reference index. Seems like deleting files directly in the filesystem still makes TYPO3 choke beyond recovery. -
Philipp Gampe commented on patch set 2 V +1 09/06/15, 00:35
ended up deleting all missing=1 from database :( -
Stephan Großberndt commented on patch set 2 09/07/15, 17:37
Feature-56726-TriggerMetadataExtractionAfterFileUpload.rst:8two spaces -
Frans Saris uploaded patch set 3 09/07/15, 19:20
-
Frans Saris commented on patch set 2 09/07/15, 19:20
Feature-56726-TriggerMetadataExtractionAfterFileUpload.rst:8ReplyDone -
Georg Ringer voted on patch set 3 CR +1 V +1 09/07/15, 19:24
-
Wouter Wolters commented on patch set 3 CR -1 09/07/15, 20:05
The RST contains several wrong wordings, will fix them.Feature-56726-TriggerMetadataExtractionAfterFileUpload.rst:12"to have to" is not correct IMO fileUpload is not a word. -
Wouter Wolters uploaded patch set 4 09/07/15, 20:10
-
Wouter Wolters voted on patch set 4 V +1 CR +1 09/07/15, 20:10
-
Georg Ringer voted on patch set 4 CR +2 V +2 09/07/15, 20:14
-
Georg Ringer merged patch set 4 09/07/15, 20:14