Review TYPO3_6-2 Abandoned

43067[BUGFIX] Allow protocol-relative url in rte for firefox

Nicolas Forgeot CR 0 V 0 Easy +1 −1 updated 01/10/16, 12:19

Commit message

Prevent adding a base url if the url is protocol-relative. An firefox
behaviour need to a base url, see getAttributes function else if (Ext.isGecko)

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 6

  1. Nicolas Forgeot uploaded patch set 1 09/06/15, 10:09

  2. Nicolas Forgeot updated the commit message in patch set 2 09/06/15, 10:11

  3. Wouter Wolters commented on patch set 2 CR -2 09/07/15, 08:16

    Please push a patch to master branch first, when master is approved a core developer will take care of backporting. I will block this patch for now.
  4. Stefan Neufeind commented on patch set 2 09/08/15, 09:27

    without checking the patch itself ... but here is a port against master: http://review.typo3.org/43125
  5. Daniel Goerz commented on patch set 2 CR -1 V -1 01/09/16, 23:05

    Please abandon, since the original patch for master is stuck as well and a (resp. this) backport to 6.2 is very unlikely to happen to say the least.
  6. Benni Mack abandoned the change 01/10/16, 12:19

    Yeah, we'll pick that one up once the master patch got in