Review main Merged

43069[TASK] Remove redundant CSRF protection tokens and deprecate used methods

Helmut Hummel CR +2 V +2 Normal +64 −53 updated 09/07/15, 12:14

Commit message

The CSRF tokens for edit document and tce actions were introduced,
to protect these entry scripts. Since the entry scripts are removed now
and any entry point is protected with a CSRF token by default, we do not need
these additional tokens any more.

The helper methods can now also be deprecated and the check for the tokens
is removed in the controllers.

Please note that in the deprecated.php the tokens still must be checked, as
third party modules still might generate URLs to the old entry scripts and
we want to have this deprecated entry point still be protected.

Review

  • Code review CR +2
    • Markus Klein +2
    • Wouter Wolters +1
    • Christian Kuhn +1
  • Verified V +2
    • Markus Klein +2
    • Wouter Wolters +1

Issues 1

Files 26

Show 6 more files

Review log 9

  1. Helmut Hummel uploaded patch set 1 09/06/15, 14:49

  2. Wouter Wolters commented on patch set 1 09/06/15, 14:55

    Deprecation-69562-DeprecateHelperMethodsForRedundantCSRFProtection.rst:27

    editRecord > record_edit
  3. Wouter Wolters voted on patch set 1 V +1 09/06/15, 14:59

  4. Wouter Wolters uploaded patch set 2 09/06/15, 15:02

  5. Wouter Wolters voted on patch set 2 V +1 CR +1 09/06/15, 15:02

  6. Christian Kuhn voted on patch set 2 CR +1 09/07/15, 10:23

  7. Markus Klein voted on patch set 2 CR +2 V +2 09/07/15, 11:37

  8. Markus Klein merged patch set 2 09/07/15, 11:38

  9. Helmut Hummel commented on patch set 3 09/07/15, 12:14

    cool, thanks!