Review TYPO3_6-2 Merged

43096[TASK] Remove wrong datasets in sanitizeLocalUrlValidPathsDataProvider

Nicole Hummel CR +2 V +2 Easy +0 −0 updated 09/07/15, 16:50

Commit message

Within the GeneralUtilityTest::sanitizeLocalUrlValidPathsDataProvider
are still wrong dataset unfortunately. As on Windows systems the
GeneralUtility::getIndpEnv('TYPO3_SITE_URL') results in
http://D:/AbsolutePathToTypo3Installation those test were moved to an
own DataProvider which makes sure the HTTP_HOST and SCRIPT_NAME are set
correctly before calling GeneralUtility::getIndpEnv().

Review

  • Code review CR +2
    • Wouter Wolters +2
  • Verified V +2
    • Wouter Wolters +2

Issues 1

Files 1

Review log 3

  1. Nicole Hummel uploaded patch set 1 09/07/15, 13:36

  2. Wouter Wolters voted on patch set 1 V +2 CR +2 09/07/15, 16:50

  3. Wouter Wolters merged patch set 1 09/07/15, 16:50