43114[BUGFIX] Use CharsetConverter for strtolower of FAL identifier
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Markus Klein +1
-
Verified V +2
- Anja Leichsenring +2
- Markus Klein +1
Issues 1
Files 2
Review log 16
-
Georg Ringer uploaded patch set 1 09/08/15, 04:23
-
Alexander Opitz voted on patch set 1 CR +1 09/08/15, 07:38
-
Stefan Froemken commented on patch set 1 CR -1 09/30/15, 13:47
Give me a hint, why we should leave it as it is, and I will remove my -1.AbstractHierarchicalFilesystemDriver.php:66Sorry, canonicalizeAndCheckFileIdentifier was called over a hundred times in some cases. I don't like the idea to call makeInstance as often. -
Oliver Hader uploaded patch set 2 10/09/15, 00:15
-
Sebastian Mazza uploaded patch set 3 11/24/15, 09:56
-
Sebastian Mazza uploaded patch set 4 11/24/15, 10:07
-
Alexander Opitz commented on patch set 4 11/24/15, 14:36
AbstractHierarchicalFilesystemDriver.php:46Duplicating source from: - GraphicalFunctions.php - LocallangArrayParser.php - LocalDriver.php - BasicFileUtility.php and maybe more places. -
Sebastian Mazza commented on patch set 4 11/24/15, 14:46
@Alexander Opitz: I have moved the code from LocalDriver to AbstractHierarchicalFilesystemDriver (AbstractHierarchicalFilesystemDriver extends the LocalDriver) therefor the count of code duplications at least doesn't increase. -
Markus Klein uploaded patch set 5 01/14/16, 17:37
-
Markus Klein uploaded patch set 6 01/14/16, 17:38
-
Markus Klein voted on patch set 6 CR +1 V +1 01/14/16, 17:38
-
Markus Klein uploaded patch set 7 01/14/16, 17:40
-
Markus Klein uploaded patch set 8 01/14/16, 17:40
-
Markus Klein voted on patch set 8 CR +1 V +1 01/14/16, 17:41
-
Anja Leichsenring voted on patch set 8 CR +2 V +2 01/14/16, 17:41
-
Gerrit merged patch set 8 01/14/16, 17:41