Review main Merged

43114[BUGFIX] Use CharsetConverter for strtolower of FAL identifier

Georg Ringer CR +2 V +2 Easy +21 −21 updated 01/14/16, 17:41

Commit message

Avoid using strtolower directly, instead use the CharsetConverter

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Markus Klein +1
  • Verified V +2
    • Anja Leichsenring +2
    • Markus Klein +1

Issues 1

Files 2

Review log 16

  1. Georg Ringer uploaded patch set 1 09/08/15, 04:23

  2. Alexander Opitz voted on patch set 1 CR +1 09/08/15, 07:38

  3. Stefan Froemken commented on patch set 1 CR -1 09/30/15, 13:47

    Give me a hint, why we should leave it as it is, and I will remove my -1.

    AbstractHierarchicalFilesystemDriver.php:66

    Sorry, canonicalizeAndCheckFileIdentifier was called over a hundred times in some cases. I don't like the idea to call makeInstance as often.
  4. Oliver Hader uploaded patch set 2 10/09/15, 00:15

  5. Sebastian Mazza uploaded patch set 3 11/24/15, 09:56

  6. Sebastian Mazza uploaded patch set 4 11/24/15, 10:07

  7. Alexander Opitz commented on patch set 4 11/24/15, 14:36

    AbstractHierarchicalFilesystemDriver.php:46

    Duplicating source from: - GraphicalFunctions.php - LocallangArrayParser.php - LocalDriver.php - BasicFileUtility.php and maybe more places.
  8. Sebastian Mazza commented on patch set 4 11/24/15, 14:46

    @Alexander Opitz: I have moved the code from LocalDriver to AbstractHierarchicalFilesystemDriver (AbstractHierarchicalFilesystemDriver extends the LocalDriver) therefor the count of code duplications at least doesn't increase.
  9. Markus Klein uploaded patch set 5 01/14/16, 17:37

  10. Markus Klein uploaded patch set 6 01/14/16, 17:38

  11. Markus Klein voted on patch set 6 CR +1 V +1 01/14/16, 17:38

  12. Markus Klein uploaded patch set 7 01/14/16, 17:40

  13. Markus Klein uploaded patch set 8 01/14/16, 17:40

  14. Markus Klein voted on patch set 8 CR +1 V +1 01/14/16, 17:41

  15. Anja Leichsenring voted on patch set 8 CR +2 V +2 01/14/16, 17:41

  16. Gerrit merged patch set 8 01/14/16, 17:41