Review main Abandoned

43125[BUGFIX] Allow protocol-relative url in RTE for firefox

Stefan Neufeind CR 0 V 0 Easy +1 −1 updated 05/04/17, 18:31

Commit message

When using Firefox the RTE strips off a URL which has no fixed protocol
(like "//www.nu.nl/") and prepends the current base URL, which
effectively breaks the source code of the RTE content.

Firefox's behaviour needs a base URL,
see getAttributes function else if (Ext.isGecko).

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 2223

  1. Stefan Neufeind uploaded patch set 1 09/08/15, 09:26

  2. Stefan Neufeind commented on patch set 1 09/08/15, 09:28

    Didn't yet check/judge the patch itself. Just a port of what was proposed/pushed by Nicolas for 6.2 (originally at https://review.typo3.org/43067)
  3. Stefan Neufeind voted on patch set 1 CR +1 11/21/15, 09:17

  4. Stefan Neufeind commented on patch set 1 11/21/15, 09:17

    fix up the description a bit
  5. Markus Klein commented on patch set 1 11/30/15, 23:55

    commit message is unclear to me.
  6. Jigal van Hemert commented on patch set 1 CR -1 V -1 12/06/15, 13:26

    DOM.js:481

    ^([a-z0-9_]{2,}\:)?\/\/ is the correct regexp.
  7. Jigal van Hemert commented on patch set 2 12/06/15, 13:33

    Published edit on patch set 1
  8. Jigal van Hemert voted on patch set 2 CR +1 V +1 12/06/15, 13:34

  9. Markus Klein commented on patch set 2 CR -1 12/06/15, 14:06

    Still a -1, because I don't get the commit message at all. Please rephrase and explain what is going on here. @Jigal: I currently fail to see what was wrong with the regex from set 1? Yours is definitely faster.
  10. Jigal van Hemert commented on patch set 2 12/06/15, 14:21

    > Still a -1, because I don't get the commit message at all. > Please rephrase and explain what is going on here. It's explained in the forge issue. > @Jigal: I currently fail to see what was wrong with the regex from > set 1? Yours is definitely faster. The original regexp had a class containing two (escaped) slashes as alternation for a normal protocol. So, it also matched a string starting with a single switch. I just made a simpler regexp to make it easier to see what it does (the added speed is a bonus).
  11. Jigal van Hemert commented on patch set 2 12/06/15, 14:22

    > starting with a single switch. ... a single SLASH. (oeps)
  12. Markus Klein commented on patch set 2 12/06/15, 14:30

    Damn... I totally overlooked those [] :-D > An firefox behaviour need to a base url, That's the part I don't get. It's not even a correct sentence.
  13. Benni Mack updated the commit message in patch set 3 04/01/16, 12:48

  14. Benni Mack voted on patch set 3 CR +1 V +1 04/01/16, 12:48

  15. Markus Klein updated the commit message in patch set 4 04/01/16, 12:57

  16. Jigal van Hemert commented on patch set 4 CR +2 V +2 04/01/16, 13:33

    Re-applying votes as code wasn't changed; tested again with new FF.
  17. Jigal van Hemert commented on patch set 4 CR +1 V +1 04/01/16, 13:34

    Changed to +1, as Benni's votes were already outdated by a changed commit message.
  18. Markus Klein voted on patch set 4 CR +1 04/01/16, 18:35

  19. Daniel Goerz commented on patch set 4 04/01/16, 19:43

    Sorry, I dont get it. If I paste //www.nu.nl/ in the RTE I get the exact same behavior and result with and without the patch in FF 45 on OS X 10. What do I have to look at to verify?
  20. Frank Nägler voted on patch set 4 CR +1 04/04/16, 12:50

  21. Frank Nägler commented on patch set 4 V -1 04/04/16, 13:04

    can't verfiy it... 1) Add text "foo" to the RTE and click the link button, add link: //www.nu.nl 2) save 3) Link is: <a href="http:////www.nu.nl/">foo</a>; 4) save again 5) Link is: <a href="http://t37.local.typo3.org/http:////www.nu.nl/">foo</a>;
  22. TYPO3com voted on patch set 4 V +1 12/04/16, 11:27 Completed build in 30m 52s on Sun, 4 Dec, 12:27 PM Test Summary: 54322 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5478

  23. Wouter Wolters abandoned the change 05/04/17, 18:31

    will not happen for master anymore. If this is still needed please create a PR on github https://github.com/FriendsOfTYPO3/rtehtmlarea