Review main Merged

43224[BUGFIX] Check for empty select icon setting in TcaMigration

Alexander Stehlik CR +2 V +2 Easy +1 −1 updated 09/12/15, 14:01

Commit message

The migrateExtAndSysextPathToEXTPath() method in the TcaMigration
checks if the icon path setting is empty before building the
paths.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Nicole Hummel +2
  • Verified V +2
    • Christian Kuhn +2
    • Nicole Hummel +2
    • Andreas Kienast +1
    • Michael Oehlhof +1

Issues 1

Files 1

Review log 8

  1. Alexander Stehlik uploaded patch set 1 09/12/15, 07:58

  2. Alexander Stehlik updated the commit message in patch set 2 09/12/15, 08:01

  3. Andreas Kienast updated the commit message in patch set 3 09/12/15, 09:50

  4. Andreas Kienast commented on patch set 3 V +1 09/12/15, 09:51

    Solution works, but I'm not sure if this should be solved somewhere else in the FlexForm handling. Let's wait for lollis review.
  5. Michael Oehlhof voted on patch set 3 V +1 09/12/15, 11:28

  6. Nicole Hummel voted on patch set 3 CR +2 V +2 09/12/15, 13:05

  7. Christian Kuhn voted on patch set 3 CR +2 V +2 09/12/15, 14:00

  8. Christian Kuhn merged patch set 3 09/12/15, 14:01