43231[BUGFIX] Improve test class detection in ClassLoadingInformationGenerator
Commit message
Review
-
Code review CR -1
- Nicole Hummel +2
- Loek Hilgersom -1
- Mathias Brodala +1
- Helmut Hummel +1
-
Verified V +2
- Nicole Hummel +2
- Mathias Brodala +1
- Helmut Hummel +1
Issues 1
Files 2
Review log 21
-
Nicole Hummel uploaded patch set 1 09/12/15, 09:54
-
Helmut Hummel voted on patch set 1 CR +1 09/12/15, 10:09
-
Mathias Brodala commented on patch set 1 CR -1 09/12/15, 10:49
-
Mathias Brodala voted on patch set 1 CR 0 09/12/15, 10:54
-
Mathias Brodala commented on patch set 1 09/12/15, 10:55
ClassLoadingInformationGenerator.php:105ReplyNo it doesn't, see "i" modifier. -
Mathias Brodala voted on patch set 1 CR +1 09/12/15, 12:25
-
Loek Hilgersom updated the commit message in patch set 2 09/13/15, 12:43
-
Loek Hilgersom commented on patch set 2 09/13/15, 12:51
For testing I created 4 class files with the following names: getLatest.php, getLaTest.php, getLost.php, get_test.php In the old situation, only getLost.php gets loaded. In the new situation, getLost.php and get_test.php are loaded. Shouldn't getLatest.php also get loaded? It's quite well possible that words end with ...test, it would avoid classes mysteriously not being loaded. What'd you think? -
Mathias Brodala commented on patch set 2 09/13/15, 12:56
I agree. Maybe it's safer to check for "\\tests\\" within the FQCN instead? -
Nicole Hummel uploaded patch set 3 09/13/15, 13:36
-
Nicole Hummel commented on patch set 3 09/13/15, 13:37
We do not know if we have a class name with namespaces. I added more tests and changed the regular expression slightly. IMHO using the psr-4 option in composer.json or ext_emconf.php should be the way to go! -
Mathias Brodala uploaded patch set 4 09/13/15, 14:29
-
Mathias Brodala commented on patch set 4 09/13/15, 14:29
Added class name from commit message, slightly cleaned up test code. -
Helmut Hummel commented on patch set 4 09/13/15, 15:23
ClassLoadingInformationGenerator.php:105that ucfirst does not make sense. we can specify the correct string above instead -
Nicole Hummel uploaded patch set 5 09/13/15, 15:48
-
Helmut Hummel uploaded patch set 6 09/13/15, 15:57
-
Helmut Hummel voted on patch set 6 CR +1 V +1 09/13/15, 15:57
-
Mathias Brodala voted on patch set 6 V +1 CR +1 09/13/15, 16:03
-
Nicole Hummel voted on patch set 6 CR +2 V +2 09/13/15, 16:05
-
Loek Hilgersom commented on patch set 6 CR -1 09/13/15, 16:05
Sorry, I believe the [A-Za-z] was correct, it could also be two capitals following eachother. 1 more round? -
Nicole Hummel merged patch set 6 09/13/15, 16:07
ClassLoadingInformationGenerator.php:105