Review main Merged

43253[BUGFIX] Pass ext_emconf.php errors

Mathias Brodala CR +2 V +2 Easy +7 −2 updated 09/12/15, 23:44

Commit message

Make sure to show the specific errors why parsing the
ext_emconf.php has failed.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Jigal van Hemert +1
  • Verified V +2
    • Christian Kuhn +2
    • Jigal van Hemert +1

Issues 1

Files 1

Review log 10

  1. Mathias Brodala uploaded patch set 1 09/12/15, 20:10

  2. Nicole Hummel commented on patch set 1 CR -1 09/12/15, 21:07

    PackageManager.php:892

    We can simple remove the try...catch block if you want to see the thrown exceptions?! But maybe I don't get the goal of this patch.
  3. Jigal van Hemert commented on patch set 1 09/12/15, 21:11

    PackageManager.php:895

    Why not simply check here if $e->getMessage() is filled and re-throw that exception.
  4. Nicole Hummel commented on patch set 1 09/12/15, 21:14

    PackageManager.php:895 Reply

    Where do we get an empty exception?
  5. Mathias Brodala commented on patch set 1 09/12/15, 21:18

    PackageManager.php:892 Reply

    The 1st one is to keep throwing the same exception (composer.json/ext_emconf.php is missing) as before.

    PackageManager.php:895 Reply

    See above.
  6. Nicole Hummel uploaded patch set 2 09/12/15, 21:57

  7. Jigal van Hemert commented on patch set 2 CR +1 V +1 09/12/15, 22:58

    Much better!
  8. Christian Kuhn voted on patch set 2 CR +2 V +2 09/12/15, 23:15

  9. Christian Kuhn merged patch set 2 09/12/15, 23:15

  10. Nicole Hummel commented on patch set 3 09/12/15, 23:44

    I would have loved to get some feedback here from Helmut before merging it