43253[BUGFIX] Pass ext_emconf.php errors
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Jigal van Hemert +1
-
Verified V +2
- Christian Kuhn +2
- Jigal van Hemert +1
Issues 1
Files 1
Review log 10
-
Mathias Brodala uploaded patch set 1 09/12/15, 20:10
-
Nicole Hummel commented on patch set 1 CR -1 09/12/15, 21:07
-
Jigal van Hemert commented on patch set 1 09/12/15, 21:11
PackageManager.php:895Why not simply check here if $e->getMessage() is filled and re-throw that exception. -
Nicole Hummel commented on patch set 1 09/12/15, 21:14
PackageManager.php:895ReplyWhere do we get an empty exception? -
Mathias Brodala commented on patch set 1 09/12/15, 21:18
PackageManager.php:892ReplyThe 1st one is to keep throwing the same exception (composer.json/ext_emconf.php is missing) as before.PackageManager.php:895ReplySee above. -
Nicole Hummel uploaded patch set 2 09/12/15, 21:57
-
Jigal van Hemert commented on patch set 2 CR +1 V +1 09/12/15, 22:58
Much better! -
Christian Kuhn voted on patch set 2 CR +2 V +2 09/12/15, 23:15
-
Christian Kuhn merged patch set 2 09/12/15, 23:15
-
Nicole Hummel commented on patch set 3 09/12/15, 23:44
I would have loved to get some feedback here from Helmut before merging it
PackageManager.php:892