Review main Merged

43262[BUGFIX] Update hide/unhide action title after AJAX call

Mathias Brodala CR +2 V +2 Easy +16 −2 updated 09/13/15, 15:20

Commit message

The title of the hide/unhide action in the record list module
must be updated after a toggle via AJAX similarly to the icon.

Review

  • Code review CR +2
    • Nicole Hummel +2
    • Alexander Stehlik +1
    • Jan Helke +1
  • Verified V +2
    • Nicole Hummel +2
    • Alexander Stehlik +1
    • Jan Helke +1

Issues 1

Files 2

Review log 14

  1. Mathias Brodala uploaded patch set 1 09/13/15, 10:36

  2. Alexander Stehlik commented on patch set 1 09/13/15, 13:31

    Hmm, after clicking the hide / unhide button the tooltip will not be hidden when moving the mouse away from the button. I need to click somewhere to hide the tooltip (in Google Chrome). Not sure if this is related.
  3. Mathias Brodala uploaded patch set 2 09/13/15, 13:53

  4. Mathias Brodala commented on patch set 2 09/13/15, 13:54

    Tooltip is now updated immediately by hiding and showing again.
  5. Nicole Hummel commented on patch set 2 V -1 09/13/15, 14:03

    The tooltip still has a problem with switching the state multiple times. After three times it is broken and the text isn't updated anymore
  6. Mathias Brodala uploaded patch set 3 09/13/15, 14:06

  7. Mathias Brodala commented on patch set 3 09/13/15, 14:07

    Fixed title update after the 3rd toggle.
  8. Alexander Stehlik commented on patch set 3 CR +1 V +1 09/13/15, 14:09

    Nice :)
  9. Nicole Hummel uploaded patch set 4 09/13/15, 14:39

  10. Nicole Hummel voted on patch set 4 CR +1 V +1 09/13/15, 14:39

  11. Alexander Stehlik voted on patch set 4 CR +1 V +1 09/13/15, 14:48

  12. Jan Helke voted on patch set 4 CR +1 V +1 09/13/15, 14:55

  13. Nicole Hummel voted on patch set 4 CR +2 V +2 09/13/15, 15:20

  14. Nicole Hummel merged patch set 4 09/13/15, 15:20