Review main Merged

43270[BUGFIX] Notify user about insufficient language configuration

Nicole Hummel CR +2 V +2 Normal +89 −1 updated 09/16/15, 13:57

Commit message

The language records are necessary within FormEngine and FlexForm
handling. If a language has a missing language_isocode, the output of
RTE elements might break because of missing identifier information.
This patch adds a notification to the user to check the language
record configuration and set a proper language_isocode.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Thorsten Bringewatt +1
  • Verified V +2
    • Christian Kuhn +2
    • Thorsten Bringewatt +1

Issues 1

Files 3

Review log 21

  1. Nicole Hummel uploaded patch set 1 09/13/15, 11:43

  2. Jan Helke voted on patch set 1 CR +1 V +1 09/13/15, 11:57

  3. Mathias Brodala uploaded patch set 2 09/13/15, 13:04

  4. Mathias Brodala commented on patch set 1 09/13/15, 13:05

    Shortened message and included record UID.
  5. Mathias Brodala voted on patch set 2 CR +1 09/13/15, 13:05

  6. Jan Helke voted on patch set 2 CR +1 V +1 09/13/15, 13:55

  7. Markus Klein updated the commit message in patch set 3 09/13/15, 15:55

  8. Markus Klein voted on patch set 3 CR +1 09/13/15, 15:56

  9. Mathias Brodala voted on patch set 3 CR +1 09/13/15, 15:57

  10. Jan Helke voted on patch set 3 CR +1 09/13/15, 16:44

  11. Susi Moog voted on patch set 3 CR +1 V +1 09/14/15, 11:56

  12. Wouter Wolters commented on patch set 3 CR -1 09/14/15, 20:32

    DatabaseSystemLanguageRows.php:89

    include this as complete use statement please

    DatabaseSystemLanguageRows.php:92

    include this as complete use statement please
  13. Nicole Hummel commented on patch set 3 09/15/15, 00:15

    DatabaseSystemLanguageRows.php:89 Reply

    Any explanation why?
  14. Wouter Wolters commented on patch set 3 09/15/15, 05:51

    DatabaseSystemLanguageRows.php:89 Reply

    Because we agreed on that and changed the core accordingly
  15. Nicole Hummel uploaded patch set 4 09/15/15, 15:26

  16. Thorsten Bringewatt voted on patch set 4 CR +1 V +1 09/16/15, 09:04

  17. Christian Kuhn commented on patch set 4 V -1 09/16/15, 13:48

    on it.
  18. Christian Kuhn uploaded patch set 5 09/16/15, 13:54

  19. Thorsten Bringewatt voted on patch set 5 CR +1 V +1 09/16/15, 13:57

  20. Christian Kuhn voted on patch set 5 CR +2 V +2 09/16/15, 13:57

  21. Christian Kuhn merged patch set 5 09/16/15, 13:57