Review main Merged

43278[TASK] Streamline select field value handling

Alexander Stehlik CR +2 V +2 Hard +473 −325 updated 09/15/15, 06:38

Commit message

The TcaSelectValues form data provider is merged in the
TcaSelectItems provider.

The possible select items are classified in dynamic items that
come from a foreign_table and static items that come from TCA,
PageTS etc.

The value for single item select fields (the default) will not
be processed because the handling of invalid values will currently
be done by the select field element renderer.

If the values from a multi value select field come from statically
defined items (e.g. items directly added in the TCA) the value will
always be added to the list of selected values.

If the values comes from dynamic select items from a database
relation the select values will only be added when they were
validated by the RelationHandler.

Finally the selected values are parsed by array_unique to prevent
duplicate entries.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Nicole Hummel +2
    • Morton Jonuschat +1
  • Verified V +2
    • Wouter Wolters +2
    • Nicole Hummel +2
    • Morton Jonuschat +1

Issues 1

Files 5

Review log 30

Show 5 earlier messages
  1. Alexander Stehlik uploaded patch set 1 09/13/15, 15:28

  2. Alexander Stehlik commented on patch set 1 V -1 09/13/15, 15:40

    Problems with single value select fields.
  3. Alexander Stehlik uploaded patch set 2 09/13/15, 16:55

  4. Alexander Stehlik uploaded patch set 3 09/13/15, 17:40

  5. Wouter Wolters commented on patch set 3 09/13/15, 20:39

    TcaSelectValues.php:38

    one tab too much here
  1. Morton Jonuschat uploaded patch set 4 09/13/15, 20:51

  2. Nicole Hummel commented on patch set 4 CR -1 09/13/15, 21:09

    On it
  3. Nicole Hummel uploaded patch set 5 09/13/15, 22:49

  4. Nicole Hummel voted on patch set 5 CR +1 V +1 09/13/15, 22:50

  5. Morton Jonuschat voted on patch set 5 CR +1 V +1 09/14/15, 07:48

  6. Alexander Stehlik commented on patch set 5 CR -1 09/14/15, 08:05

    Looking into it, need to add tests
  7. Nicole Hummel uploaded patch set 6 09/14/15, 11:00

  8. Alexander Stehlik uploaded patch set 7 09/14/15, 11:12

  9. Nicole Hummel voted on patch set 7 CR +1 V +1 09/14/15, 11:26

  10. Morton Jonuschat voted on patch set 7 CR +1 V +1 09/14/15, 12:37

  11. Alexander Stehlik commented on patch set 7 CR -1 09/14/15, 12:50

    Merging TcaSelectValue provider as discussed with lolli. Please hold.
  12. Alexander Stehlik uploaded patch set 8 09/14/15, 14:11

  13. Nicole Hummel commented on patch set 8 CR -1 09/14/15, 15:10

    On it

    TcaSelectItems.php:75

    We do not need $allItems. You can just use $fieldConfig['config']['items'] in your array_diff_key()
  14. Nicole Hummel uploaded patch set 9 09/14/15, 15:21

  15. Nicole Hummel voted on patch set 9 CR +1 V +1 09/14/15, 15:21

  16. Morton Jonuschat voted on patch set 9 CR +1 V +1 09/14/15, 15:39

  17. Christian Kuhn commented on patch set 9 CR -1 09/14/15, 16:14

    :) alex will push a last change.
  18. Alexander Stehlik uploaded patch set 10 09/14/15, 16:27

  19. Wouter Wolters voted on patch set 10 V +1 CR +1 09/14/15, 21:07

  20. Nicole Hummel commented on patch set 10 CR -1 09/14/15, 23:54

    Will push the last patch set
  21. Nicole Hummel uploaded patch set 11 09/15/15, 00:03

  22. Nicole Hummel commented on patch set 11 CR +2 V +2 09/15/15, 00:03

    Ready for merging
  23. Morton Jonuschat voted on patch set 11 CR +1 V +1 09/15/15, 05:57

  24. Wouter Wolters voted on patch set 11 V +2 CR +2 09/15/15, 06:37

  25. Wouter Wolters merged patch set 11 09/15/15, 06:38