43278[TASK] Streamline select field value handling
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Nicole Hummel +2
- Morton Jonuschat +1
-
Verified V +2
- Wouter Wolters +2
- Nicole Hummel +2
- Morton Jonuschat +1
Issues 1
Files 5
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaSelectItems.php1+128 −29
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaSelectValues.php1deleted+0 −124
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaSelectItemsTest.php+344 −9
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaSelectValuesTest.phpdeleted+0 −157
- typo3/sysext/core/Configuration/DefaultConfiguration.php+1 −6
Review log 30
Show 5 earlier messages
-
Alexander Stehlik uploaded patch set 1 09/13/15, 15:28
-
Alexander Stehlik commented on patch set 1 V -1 09/13/15, 15:40
Problems with single value select fields. -
Alexander Stehlik uploaded patch set 2 09/13/15, 16:55
-
Alexander Stehlik uploaded patch set 3 09/13/15, 17:40
-
Wouter Wolters commented on patch set 3 09/13/15, 20:39
TcaSelectValues.php:38one tab too much here
-
Morton Jonuschat uploaded patch set 4 09/13/15, 20:51
-
Nicole Hummel commented on patch set 4 CR -1 09/13/15, 21:09
On it -
Nicole Hummel uploaded patch set 5 09/13/15, 22:49
-
Nicole Hummel voted on patch set 5 CR +1 V +1 09/13/15, 22:50
-
Morton Jonuschat voted on patch set 5 CR +1 V +1 09/14/15, 07:48
-
Alexander Stehlik commented on patch set 5 CR -1 09/14/15, 08:05
Looking into it, need to add tests -
Nicole Hummel uploaded patch set 6 09/14/15, 11:00
-
Alexander Stehlik uploaded patch set 7 09/14/15, 11:12
-
Nicole Hummel voted on patch set 7 CR +1 V +1 09/14/15, 11:26
-
Morton Jonuschat voted on patch set 7 CR +1 V +1 09/14/15, 12:37
-
Alexander Stehlik commented on patch set 7 CR -1 09/14/15, 12:50
Merging TcaSelectValue provider as discussed with lolli. Please hold. -
Alexander Stehlik uploaded patch set 8 09/14/15, 14:11
-
Nicole Hummel commented on patch set 8 CR -1 09/14/15, 15:10
On itTcaSelectItems.php:75We do not need $allItems. You can just use $fieldConfig['config']['items'] in your array_diff_key() -
Nicole Hummel uploaded patch set 9 09/14/15, 15:21
-
Nicole Hummel voted on patch set 9 CR +1 V +1 09/14/15, 15:21
-
Morton Jonuschat voted on patch set 9 CR +1 V +1 09/14/15, 15:39
-
Christian Kuhn commented on patch set 9 CR -1 09/14/15, 16:14
:) alex will push a last change. -
Alexander Stehlik uploaded patch set 10 09/14/15, 16:27
-
Wouter Wolters voted on patch set 10 V +1 CR +1 09/14/15, 21:07
-
Nicole Hummel commented on patch set 10 CR -1 09/14/15, 23:54
Will push the last patch set -
Nicole Hummel uploaded patch set 11 09/15/15, 00:03
-
Nicole Hummel commented on patch set 11 CR +2 V +2 09/15/15, 00:03
Ready for merging -
Morton Jonuschat voted on patch set 11 CR +1 V +1 09/15/15, 05:57
-
Wouter Wolters voted on patch set 11 V +2 CR +2 09/15/15, 06:37
-
Wouter Wolters merged patch set 11 09/15/15, 06:38