Review main Merged

43282[BUGFIX] Show FlashMessage if desired storage is not available

Michael Oehlhof CR +2 V +2 Easy +27 −3 updated 09/16/15, 13:43

Commit message

This exception occured when a file reference from a storage was used
on a page and the extension which provides the storage was disabled
in the extension manager.

Now a FlashMessage is shown with the uid of the file reference.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Michael Oehlhof +1
    • Nicole Hummel +1
  • Verified V +2
    • Anja Leichsenring +2
    • Michael Oehlhof +1
    • Nicole Hummel +1

Issues 1

Files 3

Review log 14

  1. Michael Oehlhof uploaded patch set 1 09/13/15, 17:45

  2. Nicole Hummel commented on patch set 1 09/13/15, 23:06

    What can a user do with this information?
  3. Nicole Hummel voted on patch set 1 V -1 09/15/15, 00:35

  4. Michael Oehlhof uploaded patch set 2 09/15/15, 08:44

  5. Mathias Brodala commented on patch set 2 CR -1 09/15/15, 13:29

    BackendUtility.php:1642

    How about casting this to (int) instead? It seems like ResourceFactory::getFileReferenceObject() simply doesn't like this. (And should declare @throws actually.)
  6. Mathias Brodala uploaded patch set 3 09/15/15, 13:31

  7. Mathias Brodala commented on patch set 3 CR -1 09/15/15, 13:32

    See comment on patch set 2
  8. Nicole Hummel commented on patch set 3 CR -1 09/15/15, 13:36

    Wrong commit message
  9. Nicole Hummel uploaded patch set 4 09/15/15, 15:14

  10. Nicole Hummel uploaded patch set 5 09/15/15, 15:20

  11. Nicole Hummel voted on patch set 5 CR +1 V +1 09/15/15, 15:20

  12. Michael Oehlhof commented on patch set 5 CR +1 V +1 09/16/15, 08:18

    Thanks for fine tuning and finishing to Nicole and Mathias.
  13. Anja Leichsenring voted on patch set 5 CR +2 V +2 09/16/15, 13:42

  14. Anja Leichsenring merged patch set 5 09/16/15, 13:43