Review main Abandoned

43287[BUGFIX] Warning when clearing all caches from within install tool

Bernhard Kraft CR 0 V 0 Easy +11 −5 updated 09/14/15, 09:21

Commit message

When using the "clearAllCache" button a warning message gets shown
(eventually just logged) when the APC file cache is used.

Reason is that the method "OpcodeCacheUtility::clearAllActive()"
will not allow to clear whole directories. Per definition the used
method "apc_delete_file()" allows only to delete single file-cache
entries from the APC cache when called with a string argument.

So for this to work the method "apc_delete_file()" got changed to
use the "ApcIterator" class using a regular expression matching
the given directory.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 3

  1. Bernhard Kraft uploaded patch set 1 09/14/15, 09:06

  2. Bernhard Kraft updated the commit message in patch set 2 09/14/15, 09:19

  3. Bernhard Kraft abandoned the change 09/14/15, 09:21

    Wrong branch. In 7.x this is not valid anymore (APC not supported).