Review TYPO3_6-2 Merged

43289[BUGFIX] Warning when clearing all caches from within install tool

Bernhard Kraft CR +2 V +2 Easy +11 −5 updated 04/04/16, 13:08

Commit message

When using the "clearAllCache" button a warning message gets shown
(or eventually just logged) when the APC file cache is used.

Reason is that the method "OpcodeCacheUtility::clearAllActive()"
will not allow to clear whole directories. Per definition the used
method "apc_delete_file()" allows only to delete single file-cache
entries from the APC cache when called with a string argument.

So for this to work the method "apc_delete_file()" got changed to
use the "ApcIterator" class using a regular expression matching
the given directory.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Daniel Goerz +1
    • Markus Klein +1
    • Christian Kuhn +1
  • Verified V +2
    • Frank Nägler +2
    • Christian Kuhn +1

Issues 1

Files 2

Review log 13

  1. Bernhard Kraft uploaded patch set 1 09/14/15, 09:20

  2. Stefan Froemken commented on patch set 1 V -1 CR -1 09/14/15, 13:04

    OpcodeCacheUtility.php:87

    apc_exists checks if a key exists in user storage and not in OpCache. I have debugged it multiple times now, but f.e. ext_localconf_ftj854o2tzo9zto3zmt8o2gh.php was never be deleted. So try to call apc_delete_file directly with "else"
  3. Bernhard Kraft wrote 01/15/16, 22:04

    Patch set 2: Published edit on patch set 1.
  4. Anja Leichsenring voted on patch set 2 CR +1 01/17/16, 11:53

  5. Stefan Froemken commented on patch set 2 01/20/16, 07:41

    OpcodeCacheUtility.php:87

    I miss the else part for deleting a single file from APC cache here. Can you give me a hint why you have removed it?
  6. Frank Nägler commented on patch set 2 CR -1 01/23/16, 21:10

    OpcodeCacheUtility.php:87 Reply

    agree with Stefan, please add an else case to delete it, if $fileAbsPath is not a directory.
  7. Daniel Goerz uploaded patch set 3 04/01/16, 20:28

  8. Daniel Goerz voted on patch set 3 CR +1 04/01/16, 20:29

  9. Markus Klein voted on patch set 3 CR +1 04/01/16, 21:12

  10. Frank Nägler voted on patch set 3 CR +1 04/04/16, 13:07

  11. Christian Kuhn voted on patch set 3 CR +1 V +1 04/04/16, 13:08

  12. Frank Nägler voted on patch set 3 CR +2 V +2 04/04/16, 13:08

  13. Gerrit merged patch set 3 04/04/16, 13:08