43289[BUGFIX] Warning when clearing all caches from within install tool
Commit message
Review
-
Code review CR +2
- Frank Nägler +2
- Daniel Goerz +1
- Markus Klein +1
- Christian Kuhn +1
-
Verified V +2
- Frank Nägler +2
- Christian Kuhn +1
Issues 1
Files 2
Review log 13
-
Bernhard Kraft uploaded patch set 1 09/14/15, 09:20
-
Stefan Froemken commented on patch set 1 V -1 CR -1 09/14/15, 13:04
-
Bernhard Kraft wrote 01/15/16, 22:04
Patch set 2: Published edit on patch set 1. -
Anja Leichsenring voted on patch set 2 CR +1 01/17/16, 11:53
-
Stefan Froemken commented on patch set 2 01/20/16, 07:41
OpcodeCacheUtility.php:87I miss the else part for deleting a single file from APC cache here. Can you give me a hint why you have removed it? -
Frank Nägler commented on patch set 2 CR -1 01/23/16, 21:10
OpcodeCacheUtility.php:87Replyagree with Stefan, please add an else case to delete it, if $fileAbsPath is not a directory. -
Daniel Goerz uploaded patch set 3 04/01/16, 20:28
-
Daniel Goerz voted on patch set 3 CR +1 04/01/16, 20:29
-
Markus Klein voted on patch set 3 CR +1 04/01/16, 21:12
-
Frank Nägler voted on patch set 3 CR +1 04/04/16, 13:07
-
Christian Kuhn voted on patch set 3 CR +1 V +1 04/04/16, 13:08
-
Frank Nägler voted on patch set 3 CR +2 V +2 04/04/16, 13:08
-
Gerrit merged patch set 3 04/04/16, 13:08
OpcodeCacheUtility.php:87